-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[question] HER and prioritized experience replay #751
Comments
I believe there are no bigger reasons to lack of support, other than lack of implementation. It would require coming up with prioritizes for the samples in the buffer, and then updating the |
Actually, PER has been shown not to improve performance over HER, hence there is no real motivation to imlpement. Not only does PER not improve performance, but it actually increases computational time substantially. PER works by prioritising transitions with higher TD-error, which means that the TD-error must be computed for each transition, hence the expensive computational time. Prioritised Sequence Experience Replay (PSER) outperforms PER but has not been imlpemented with HER. There are other methods which improve the sampling efficiency of HER (such as Energy Based Prioritisation), but PER is not one of them. I have put my name forward to implement this in the new PyTorch version. |
Ok, thanks for the info! Indeed any such new features would be things for the PyTorch version :). |
I added it to possible features for Stable-Baselines3 1.1+ in DLR-RM/stable-baselines3#1 |
Hi
in the stable-baselines implementation, HER does not support prioritized replay buffer. In the HER Paper they state that: "Prioritized experience replay (....) is orthogonal to our work and both approaches can be easily combined". So my question is: Are there 'deeper reasons' for the lack of support or is it just a currently missing feature?
Best Regards,
Johannes
The text was updated successfully, but these errors were encountered: