Commits on Sep 21, 2012

1. Do not read from request body unless we have to …

   HttpRequest's read() method is called when we do
   self.request.REQUEST.get('bearer_token'). This makes it impossible to
   access the request body at a later point.
   
   With this change we avoid trying to read a bearer token from the
   request body if the Authorization header is set.
   
   In django.http.HttpRequest:
   
       def read(self, *args, **kwargs):
           self._read_started = True
           return self._stream.read(*args, **kwargs)
   
       @Property
       def body(self):
           if not hasattr(self, '_body'):
               if self._read_started:
                   raise Exception("You cannot access body after reading from request's data stream")
               try:
                   self._body = self.read()
               except IOError, e:
                   raise UnreadablePostError, e, sys.exc_traceback
               self._stream = StringIO(self._body)
           return self._body

   

   pilt committed Sep 21, 2012
   Configuration menu

   • View commit details
   • Copy full SHA for 546c1a6
   • Browse repository at this point

   Copy the full SHA

   546c1a6 View commit details

   Browse the repository at this point in the history