Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort_hierarchy_with_altitudes fails if altitudes are not increasing #190

Closed
PerretB opened this issue Apr 28, 2020 · 0 comments · Fixed by #193
Closed

sort_hierarchy_with_altitudes fails if altitudes are not increasing #190

PerretB opened this issue Apr 28, 2020 · 0 comments · Fixed by #193
Labels
bug Something isn't working

Comments

@PerretB
Copy link
Member

PerretB commented Apr 28, 2020

The natural order of altitudes must be a topological ordering of the nodes of the tree, otherwise there is no solution for this function : this should stated as a precondition in c++ and enforced in python.
@PerretB PerretB added the bug Something isn't working label Apr 28, 2020
@PerretB PerretB mentioned this issue Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increasing altitudes asserts higra/Higra
1 participant
@PerretB