Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume from hibernation turns off battery threshold at 80 percent #103

Open
whatnameisit opened this issue Sep 19, 2021 · 3 comments
Open

Comments

@whatnameisit
Copy link

whatnameisit commented Sep 19, 2021

On normal use, AsusSMC 1.4.0+ caps the battery level at 80 percent if Battery Health in Energy Saver is toggled on.
When the machine resumes from hibernation, the threshold is ignored and the battery keeps on charging until 100 percent.
I'm not good with logging (and about zero knowledge in coding), so if anyone could tell me how, I'll collect the logs and upload them here.

IOReg: Battery Conservation Mode is marked true in ATK-AsusSMC
MacBook Pro.zip
Asus Dmesg output shows battery conservation mode true
Asus.log.zip
Hibernation logs Hibern hibern HBFX
hibernation.zip

@Ubsefor
Copy link
Contributor

Ubsefor commented Sep 19, 2021

This feature shouldn't work at all on non-apple hardware. I tried to use it for a bit and noticed that my battery doesn't charge correctly with this turned on: battery dies at 30-40% immediately.

I don't know whether you have the same issue or not, but I suggest at least checking it out.

@whatnameisit
Copy link
Author

I'm not sure we are on the same issue. By "this feature," did you mean battery threshold on hibernation or just the battery threshold?
Hibernation works with HibernationFixup.kext and battery threshold works with AsusSMC.kext.
When both kexts are used together, battery threshold is ignored when resuming from hibernation. A simple reboot makes the limit to kick in and prevent the charging above 80 percent again.
I don't remember experiencing the laptop shutting down at 30-40 percent battery level, if that's what you mean by battery dies at 30-40% immediately. I'm pretty sure there were times the battery level was below 25 percent and it charged fine with the battery threshold feature on.
Since you commented, do you know how to debug or collect logs on my issue?

Nevuly added a commit to Nevuly/S510UA-BQ423-Hackintosh that referenced this issue Oct 12, 2021
…number

 * HibernationFixup breaks battery threshold in AsusSMC.
 * Sometimes laptop suddenly stopped to powering on, that issue may came from hibernation.
 * Remove HibernationFixup kext and configs to avoid this issue.
 * Issue thread in AsusSMC(hieplpvip/AsusSMC#103).
 * Add Update type and Revision number to management versions.

Bug: R8EU-001
Test: Apply and Reboot

Signed-off-by: Yang Jeong Hun <[email protected]>
@whatnameisit
Copy link
Author

I fried my laptop's motherboard and sold it for 100000 won. I won't close this issue though because it's a real one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants