Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Design: Fix home navigation scroll #4

Open
captn3m0 opened this issue Jan 24, 2023 · 14 comments · May be fixed by #10
Open

Responsive Design: Fix home navigation scroll #4

captn3m0 opened this issue Jan 24, 2023 · 14 comments · May be fixed by #10

Comments

@captn3m0
Copy link
Member

The scroll for the listing on the home page is not natural. It should instead be top-to-bottom on the homepage.

image

@elidakirigo
Copy link

hello!, I'd love to work on this issue if it's still open and un-assigned. thanks

@captn3m0
Copy link
Member Author

captn3m0 commented Mar 7, 2023

Feel free to pick this up 1. My suggested solution would be to:

  1. Create vertical variants of all homenav images
  2. Write additional styles for devices with display width <1000px to switch the images to a vertical layout.

See this image for example:

homenav-vertical-1

We do have sources for the original images, but they happen to be in an ancient CPT 9 format, which I can't open.

Footnotes

  1. General advice, for small issues like these is to avoid comments "claiming" the issue, and just file a PR instead.

@elidakirigo
Copy link

sure! i'll take a look

@jlduchaney
Copy link
Contributor

Working on this for Hacktoberfest 2024!

@captn3m0
Copy link
Member Author

captn3m0 commented Oct 1, 2024

If you need any help with image conversions, do reach out.

@jlduchaney jlduchaney linked a pull request Oct 3, 2024 that will close this issue
@jlduchaney
Copy link
Contributor

Hi @captn3m0! Will you have time to review my pull requests before October 31?

If you don't have the bandwidth, I completely understand. I would just like to know if this is the case, so I can pick a different repository to work on for Hacktoberfest. Thanks in advance!

@captn3m0
Copy link
Member Author

Yes.

Since there's only single-digit pages in the entire repo, they are quite easy to review for breaking changes and correctness. As long as you take care to avoid breaking the site, should be easy to merge.

@jlduchaney
Copy link
Contributor

Thanks for the quick response. In that case, I'll continue working through the issues you've posted. Appreciate your time!

@jlduchaney
Copy link
Contributor

Hi @captn3m0! I'm gently following up here. Please let me know if your availability has changed since your last comment. Thanks!

@captn3m0
Copy link
Member Author

If it's a small PR, I'll definitely review it within a day.

@jlduchaney
Copy link
Contributor

Thanks again for getting back to me so quickly. I have four open PRs, but they're all pretty small, so I don't think it should be a problem.

@jlduchaney
Copy link
Contributor

Hi @captn3m0 ! Might you consider applying the "hacktoberfest-accepted" label to each of my four pull requests before end of day today? This way, they'll be eligible to qualify for Hacktoberfest even if you don't have time to merge them before midnight. Please let me know either way, and thanks again 😊

@captn3m0
Copy link
Member Author

I've merged the two content PRs, and applied the label on the other two (#10, #11). The diff seemed okay, but I want to review them locally once before merging.

Thanks for your contributions 🥇!

@jlduchaney
Copy link
Contributor

Thanks for your quick response, as always! I'll set aside some time this weekend to figure out the .log files.

And thank you for being so welcoming. As someone who's still learning to code, having you as a maintainer made my first-ever Hacktoberfest a positive, approachable experience. I appreciate the work you're doing to keep hginit.com alive. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants