Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black versions of moon phases symbols are not readable (from 1F311 to 1F318) #387

Open
ungual opened this issue Apr 24, 2022 · 6 comments
Open

Comments

@ungual
Copy link

ungual commented Apr 24, 2022

When using the OpenMoji-Black font, the moon phases symbols are not readable because only the outlines are kept.
We can't tell which part is the lighted side of the moon and which one is the shadow side, so for example full moon looks exactly like new moon.

Screenshot 2022-04-24 at 17-24-38

(also it seems there is something weird happening with 1F317, the yellow fill going outside of the outlines)

@b-g
Copy link
Member

b-g commented Apr 25, 2022

Many thanks for the feedback!

  • Yes 1F317 is buggy ... but the fonts are experimental and not for production. We are really struggling with the color font generation part, see the epic conversation e.g. here Build COLR TTFs with nanoemoji #260. Hence it makes no sense to invest any time in it, as a better colorfont build system might be able to deal with it
  • Yes it would be better to show all yellow shapes in black for OpenMoji-Black. A PR to fix this would be welcome :)

RobertWinslow added a commit to RobertWinslow/openmoji that referenced this issue Dec 24, 2022
Addresses hfg-gmuend#387

I added black copies of the darkened portions of each moon phase. This makes the glyphs consistent with the designs in the monochrome Noto emoji font.
@RobertWinslow
Copy link
Contributor

Here's a comparison of how these characters are being rendered in the current version of the fonts.
(In Chrome for MacOS)

From left to right: color png, glyf_colr_0 font, system default, black png, black glyf font

Screen Shot 2023-01-14 at 10 59 20 AMScreen Shot 2023-01-14 at 11 04 33 AM

@lizbravob
Copy link
Contributor

Hi 👋🏼 I hope this helps 🌕🌖🌗🌘🌑🌒🌓🌔
moon.zip

@b-g
Copy link
Member

b-g commented Jan 16, 2023

@RobertWinslow I guess your intention was to show with the table that the issues has been resolved, correct?

@lizbravob Many thanks! Probably I'm blind, but what is different in comparison to the table above? 🤷‍♂️ :)

@lizbravob
Copy link
Contributor

Oh sorry! I got confused. I thought it might help if the moon phases emojis used the special layer line-supplement for the dark mode.

@RobertWinslow
Copy link
Contributor

RobertWinslow commented Jan 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants