Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for Using cakin build for Python3 Work-Around on Melodic #48

Open
MarioGini opened this issue Sep 9, 2021 · 5 comments
Open

Comments

@MarioGini
Copy link
Contributor

As the description says, the build instructions suggest to use catkin_make when using the python3 workaround for ROS Melodic. I think that in general, using catkin build is preferred over catkin_make so maybe that section could suggest to e.g. add the additional CMake arguments to a caktin config profile using catkin config --cmake-args ...

@civerachb-cpr
Copy link
Collaborator

Realistically you can use either tool, and both will do the job of building the packages. We tend to use catkin_make in a lot of our examples as that command is automatically included (and is also what the ROS wiki uses in its tutorials).

I don't know that there would be a lot of benefit to adding the catkin build instructions when the provided instructions using catkin_make do work on Melodic. Melodic is in an awkward situation, since it exists after the Python3 EOL date, but is still stuck without official Python3 support and is stuck requiring these sorts of work-arounds.

@peci1
Copy link

peci1 commented Sep 13, 2021

catkin_make is the official Melodic tool for building packages. catkin build is an alternative implementation. I think it's good the tutorials stick with the officially distributed build system.

@civerachb-cpr civerachb-cpr changed the title Build instructions for python3 workaround on ROS Melodic use catkin_make Instructions for Using cakin build for Python3 Work-Around on Melodic Sep 13, 2021
@civerachb-cpr
Copy link
Collaborator

I've edited the title of this issue. Anyone preferring to use catkin build can find this issue and use the instructions you've provided here, rather than modifying our core instructions to use a secondary build system.

@BADAL244
Copy link

/home/agx3/ros2/devel/include/spot_msgs/LeaseArray.h:18:10: fatal error: spot_msgs/LeaseResource.h: No such file or directory
#include <spot_msgs/LeaseResource.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~

@civerachb-cpr
Copy link
Collaborator

This driver is for ROS1 (specifically Melodic and Noetic). The path to the file seems to indicate you're trying to use the driver for ROS2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants