RGB8 images are marked as big endian, why?

[peci1]

spot_ros/spot_driver/src/spot_driver/ros_helpers.py

Lines 150 to 154 in bb82c29

	# JPEG format
	if data.shot.image.format == image_pb2.Image.FORMAT_JPEG:
	image_msg.encoding = "rgb8"
	image_msg.is_bigendian = True
	image_msg.step = 3 * data.shot.image.cols

and similar are present in the camera driver part. The only little-endian thing is the 16UC1 depth image (which is correct as protobufs are always little).

Is there some reason for the single-byte values to be marked as big endian? If I understand it correctly, this has nothing to do with BGR/RGB as that is one level higher than endianness...

[heuristicus]

I don't know much about how ROS makes use of the endianness values when processing/publishing, but I suppose this might be because some things wouldn't work correctly if the endianness is left on its default of false?

Perhaps it's something to try removing and seeing if the images are still output as expected in rviz or other image viewers.

[peci1]

I've tested it with both the mono images from body cameras and with the RGB camera from arm. Nothing changed in the look of the images as viewed by image_view, rqt_image_view, rviz or rqt_bag.