Skip to content

Commit fc34267

Browse files
committed
fix blinking when toggling variant or isVertical
1 parent ae6f99a commit fc34267

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

packages/components/tabs/src/tabs.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,15 @@ const Tabs = forwardRef(function Tabs<T extends object>(
7777
const withAnimationReset = useCallback(
7878
(callback: () => void) => {
7979
if (variant !== previousVariant.current || isVertical !== previousIsVertical.current) {
80-
cursorRef.current?.removeAttribute("data-initialized");
80+
cursorRef.current?.removeAttribute("data-animated");
8181
}
8282
callback();
8383
previousVariant.current = variant;
8484
previousIsVertical.current = isVertical;
85-
requestAnimationFrame(() => cursorRef.current?.setAttribute("data-initialized", "true"));
85+
requestAnimationFrame(() => {
86+
cursorRef.current?.setAttribute("data-animated", "true");
87+
cursorRef.current?.setAttribute("data-initialized", "true");
88+
});
8689
},
8790
[isVertical, variant],
8891
);

packages/core/theme/src/components/tabs.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ const tabs = tv({
7171
"will-change-[transform,width,height]",
7272
"invisible",
7373
"data-[initialized=true]:visible",
74-
"data-[initialized=true]:transition-[left,top,width,height]",
75-
"data-[initialized=true]:duration-250",
76-
"data-[initialized=true]:ease-out",
74+
"data-[animated=true]:transition-[left,top,width,height]",
75+
"data-[animated=true]:duration-250",
76+
"data-[animated=true]:ease-out",
7777
],
7878
panel: [
7979
"py-3",

0 commit comments

Comments
 (0)