Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] external authentication state sync doesn't work #5

Open
zwhitfield3 opened this issue Jan 17, 2025 · 4 comments
Open

[BUG] external authentication state sync doesn't work #5

zwhitfield3 opened this issue Jan 17, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@zwhitfield3
Copy link

Describe the Bug
External authentication state sync doesn't work. It prompts the user to login via the happy path for VSCode extension.

To Reproduce
Steps to reproduce the behavior:

Expected Behavior
VSCode extension should successfully sync and show 'browse starter apps' in resource explorer.

Actual Behavior
VSCode prompts the user to login via the happy path for VSCode. Also, if you close that prompt and refresh the resource explorer, it gets stuck in the 'Loading...' state.

Environment:

  • OS: [e.g. Windows 11, macOS 15.2]
  • VSCode v1.96.3
  • Extension Version: v0.0.1

Screenshots
Prompt
Image

Stuck loading state if prompt is closed without authenticating via the happy path
Image

Additional Context
Add any other context about the problem here.

@zwhitfield3 zwhitfield3 added the bug Something isn't working label Jan 17, 2025
Copy link

git2gus bot commented Jan 17, 2025

This issue has been linked to a new work item: W-17620188

@zwhitfield3
Copy link
Author

Also, upon restarting VSCode, the app is still stuck if prompt is closed without re-authenticating.

@justinwilaby
Copy link
Collaborator

justinwilaby commented Jan 17, 2025

This occurs when authentication was performed on a new install outside the Heroku extension without "allowing" heroku:

Image

or when Heroku is not a "trusted" extension:

Image

To resolve this:

  1. Sign out of Heroku
  2. Make sure Heroku is a trusted extension - CMD + P (CTRL + P on Windows) then type: '>Manage trusted extensions' and check the box next to Heroku
  3. Authenticate using the "Sign in" button and choose "allow" in the dialog that opens

@zwhitfield3
Copy link
Author

I've noted that the authentication works for the integrated VSCode terminal. The issues presented here stem from using an external terminal which in this case was iTerm2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants