PHP 8.4 #767
Open
PHP 8.4 #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not have support for PHP 5 or PHP 7.[012] anymore.
We do not have support for PHP 5 or PHP 7.0 anymore.
There is no more E_STRICT for error_reporting, and session.sid_length is gone. The imap extension has moved to PECL. No blackfire or newrelic extension builds yet with support for 8.4. The phalcon extension is incompatible with 8.4 (they always get new releases some time later), and pcov needs a fix and release first: krakjoe/pcov#111 The heroku-20 stack is not getting this version because the stack is already deprecated. GUS-W-17226361
We're bumping the plugin-api-version for the no lock file present case to allow Composer 2.8 which works with PHP 8.4 (to allow clean boots, and builds without deprecation errors). This is a very inconsequential change for users that have no lock file, as no lock file means no package installs, plugins, etc.
edmorley
approved these changes
Nov 23, 2024
| else | ||
| HEROKU_PHP_DEFAULT_RUNTIME_VERSION="^8.0.0 <8.4" | ||
| HEROKU_PHP_DEFAULT_RUNTIME_VERSION="^8.0.0 <8.5" |
There was a problem hiding this comment.
If I'm reading this correctly, apps with an unspecified PHP version can now get PHP 8.4 for the first time.
However, this isn't mentioned in the changelog? (The PHP/8.4.1 entry isn't sufficient to infer that IMO - particularly since it's a .1 release, and not 8.4.0, so doesn't make it clear that this is the first new 8.4 release)
I think an additional mention in the changelog might be worthwhile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No blackfire or newrelic extension builds yet with support for 8.4. The phalcon extension is incompatible with 8.4 (they always get new releases some time later), and pcov needs a fix and release first: krakjoe/pcov#111. The imap extension has moved to PECL.
The heroku-20 stack is not getting this version because the stack is already deprecated.
GUS-W-17226361