Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Add support for -t / --team on teams #140

Open
raulb opened this issue Jan 23, 2017 · 2 comments
Open

Add support for -t / --team on teams #140

raulb opened this issue Jan 23, 2017 · 2 comments

Comments

@raulb
Copy link
Contributor

raulb commented Jan 23, 2017

There are other commands like heroku members that do support -t and --team and even encourages their use.

I think switching between commands that support this flag and others that doesn't, it might be really confusing to the user:

e.g.:

› heroku members -o my-team
[email protected]    member
[email protected]     admin
 ▸    my-team is a Heroku Team
 ▸    Heroku CLI now supports Heroku Teams.
 ▸    Use -t or --team for teams like my-team

› heroku members -t my-team
[email protected]    member
[email protected]     admin

› heroku apps -t my-team
 ▸    Error: Unexpected flag -t
 ▸    Usage: heroku apps
 ▸
 ▸    This flag is invalid for this command. Here are the accepted flags:
 ▸     -A, --all           # include apps in all organizations
 ▸     -o, --org ORG       # organization to use
 ▸     -p, --personal      # list apps in personal account when a default org is set
 ▸     -s, --space SPACE   # filter by space
 ▸     --json              # output in json format
 ▸
 ▸    See more information with heroku apps --help

cc @simpsoka @ike-delorenzo

@jdx
Copy link
Contributor

jdx commented Jan 23, 2017

It would be ideal to get a list of all the commands we need to add it to

@raulb
Copy link
Contributor Author

raulb commented Jan 24, 2017

@dickeyxxx yup, I agree. Now that I'm in DevEx, I influenced the inclusion of this flag to existing commands (see heroku/heroku-pipelines@65d3e08), but we should probably collect, from core plugins what commands currently operate with -o. Anything that meets that criteria, should probably also support t / --team.

Update, just took a glance at the current CLI core plugins, and AFAICT, only heroku-apps and heroku-spaces operate with --org. For heroku-spaces, adding -t support is not necessary since this is an Enterprise feature only (no teams), so it leaves us with just heroku-apps.

My guess is that heroku apps really is the most common one, but if I think of new ones, I'll make sure I'll open issues where they belong.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants