Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Inconsistent quoting in output of config -s #126

Open
edmorley opened this issue Sep 29, 2016 · 0 comments
Open

Inconsistent quoting in output of config -s #126

edmorley opened this issue Sep 29, 2016 · 0 comments

Comments

@edmorley
Copy link
Member

edmorley commented Sep 29, 2016

heroku config -s currently gives output like:

HEROKU_APP_NAME=foo-bar
HEROKU_RELEASE_CREATED_AT='2016-09-29T11:05:02Z'
HEROKU_RELEASE_VERSION=v58
NEW_RELIC_CONFIG_FILE='newrelic.ini'
WEB_CONCURRENCY=3

ie: some values are quoted with ', others not.

Whilst the unquoted entries don't technically need quotes, I think it would be more consistent to just always include the quotes around each value.

Currently the npm package shell-escape is used:

cli.log(`${k}=${shellescape([v])}`)

...which doesn't have a way to force quotes:
https://github.com/xxorax/node-shell-escape/blob/master/shell-escape.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant