Skip process registration with Procfile (#185)

Author: runesoerensen

buildpacks/dotnet/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Detected process types are now only registered as launch processes when no Procfile is present. [#185](https://github.com/heroku/buildpacks-dotnet/pull/185)
+
 ### Added
 
 - Enabled `libcnb`'s `trace` feature. [#184](https://github.com/heroku/buildpacks-dotnet/pull/184)

buildpacks/dotnet/src/main.rs

@@ -158,23 +158,33 @@ impl Buildpack for DotnetBuildpack {
         layers::runtime::handle(&context, &sdk_layer.path())?;
 
         log_bullet = log
-            .bullet("Setting launch table")
+            .bullet("Process types")
             .sub_bullet("Detecting process types from published artifacts");
         let mut launch_builder = LaunchBuilder::new();
         log = match launch_process::detect_solution_processes(&solution) {
             Ok(processes) => {
                 if processes.is_empty() {
-                    log_bullet = log_bullet.sub_bullet("No processes were detected");
-                }
-                for process in processes {
-                    log_bullet = log_bullet.sub_bullet(format!(
-                        "Added {}: {}",
-                        style::value(process.r#type.to_string()),
-                        process.command.join(" ")
-                    ));
-                    launch_builder.process(process);
+                    log_bullet.sub_bullet("No processes were detected").done()
+                } else {
+                    for process in &processes {
+                        log_bullet = log_bullet.sub_bullet(format!(
+                            "Found {}: {}",
+                            style::value(process.r#type.to_string()),
+                            process.command.join(" ")
+                        ));
+                    }
+                    log_bullet = if Path::exists(&context.app_dir.join("Procfile")) {
+                        log_bullet
+                            .sub_bullet("Procfile detected")
+                            .sub_bullet("Skipping process type registration (add process types to your Procfile as needed)")
+                    } else {
+                        launch_builder.processes(processes);
+                        log_bullet
+                            .sub_bullet("No Procfile detected")
+                            .sub_bullet("Registering detected process types as launch processes")
+                    };
+                    log_bullet.done()
                 }
-                log_bullet.done()
             }
             Err(error) => log_launch_process_detection_warning(error, log_bullet),
         };

buildpacks/dotnet/tests/dotnet_publish_test.rs

@@ -83,6 +83,64 @@ fn test_dotnet_publish_with_debug_configuration() {
     );
 }
 
+#[test]
+#[ignore = "integration test"]
+fn test_dotnet_publish_process_registration_with_procfile() {
+    TestRunner::default().build(
+        default_build_config("tests/fixtures/basic_web_9.0_with_procfile"),
+        |context| {
+            assert_empty!(context.pack_stderr);
+            assert_contains!(
+                &context.pack_stdout,
+                indoc! { r"
+                    - Process types
+                      - Detecting process types from published artifacts
+                      - Found `foo`: bash -c cd bin/publish; ./foo --urls http://*:$PORT
+                      - Procfile detected
+                      - Skipping process type registration (add process types to your Procfile as needed)"}
+            );
+        },
+    );
+}
+
+#[test]
+#[ignore = "integration test"]
+fn test_dotnet_publish_process_registration_without_procfile() {
+    TestRunner::default().build(
+        default_build_config("tests/fixtures/basic_web_9.0"),
+        |context| {
+            assert_empty!(context.pack_stderr);
+            assert_contains!(
+                &context.pack_stdout,
+                indoc! { r"
+                - Process types
+                  - Detecting process types from published artifacts
+                  - Found `foo`: bash -c cd bin/publish; ./foo --urls http://*:$PORT
+                  - No Procfile detected
+                  - Registering detected process types as launch processes"}
+            );
+        },
+    );
+}
+
+#[test]
+#[ignore = "integration test"]
+fn test_dotnet_publish_process_registration_without_process_types() {
+    TestRunner::default().build(
+        default_build_config("tests/fixtures/class_library"),
+        |context| {
+            assert_empty!(context.pack_stderr);
+            assert_contains!(
+                &context.pack_stdout,
+                indoc! { r"
+                - Process types
+                  - Detecting process types from published artifacts
+                  - No processes were detected"}
+            );
+        },
+    );
+}
+
 #[test]
 #[ignore = "integration test"]
 fn test_dotnet_publish_with_global_json_and_custom_verbosity_level() {

buildpacks/dotnet/tests/fixtures/basic_web_9.0_with_procfile/Procfile

@@ -0,0 +1 @@
+web: foo

buildpacks/dotnet/tests/fixtures/basic_web_9.0_with_procfile/Program.cs

@@ -0,0 +1,6 @@
+var builder = WebApplication.CreateBuilder(args);
+var app = builder.Build();
+
+app.MapGet("/", () => "Hello World!");
+
+app.Run();

buildpacks/dotnet/tests/fixtures/basic_web_9.0_with_procfile/foo.csproj

@@ -0,0 +1,10 @@
+<Project Sdk="Microsoft.NET.Sdk.Web">
+
+  <PropertyGroup>
+    <TargetFramework>net9.0</TargetFramework>
+    <Nullable>enable</Nullable>
+    <ImplicitUsings>enable</ImplicitUsings>
+  </PropertyGroup>
+
+</Project>
+

buildpacks/dotnet/tests/fixtures/class_library/Class1.cs

@@ -0,0 +1,5 @@
+namespace class_library;
+
+public class Class1
+{
+}

buildpacks/dotnet/tests/fixtures/class_library/class_library.csproj

@@ -0,0 +1,9 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net9.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+  </PropertyGroup>
+
+</Project>