chore(auth): migrate keycloak base URL to auth herodevs#576
Merged
Conversation
dannysauer
reviewed
Jun 4, 2026
dannysauer
left a comment
Contributor
There was a problem hiding this comment.
I think this looks alright, but I'm probably not an appropriate codeowner. :)
|
It looks right but that url won't be live until the 13th |
Contributor
Author
got it, will be holding off the merge/deployment until then |
facundo-herodevs
approved these changes
Jun 8, 2026
jeremymwells
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idp.prod.apps.herodevs.iodefault inauth-config.svc.tswithauth.herodevs.com/idpNES_KC_BASE/NES_KC_REALMenv var.OAUTH_CONNECT_URLas a full-URL override for backwardscompatibility.
Priority order in
getRealmUrl():OAUTH_CONNECT_URL(full URL, existing override)NES_KC_BASE+NES_KC_REALM(org Actions variables)https://auth.herodevs.com/idp+universe)Test plan
hd auth logincompletes successfully against prod (confirmsauth.herodevs.com/idpOIDC endpoints are reachable)OAUTH_CONNECT_URLstill overrides the URL (backwardscompat)
NES_KC_BASE+NES_KC_REALMconstructs the expectedrealm URL