Skip to content

chore(auth): migrate keycloak base URL to auth herodevs#576

Merged
v3nant merged 1 commit into
mainfrom
chore/migrate-kc-base-url
Jun 8, 2026
Merged

chore(auth): migrate keycloak base URL to auth herodevs#576
v3nant merged 1 commit into
mainfrom
chore/migrate-kc-base-url

Conversation

@v3nant

@v3nant v3nant commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces the hardcoded idp.prod.apps.herodevs.io default in
    auth-config.svc.ts with auth.herodevs.com/idp
  • Adopts the org-recommended NES_KC_BASE / NES_KC_REALM env var.
  • Preserves OAUTH_CONNECT_URL as a full-URL override for backwards
    compatibility.

Priority order in getRealmUrl():

  1. OAUTH_CONNECT_URL (full URL, existing override)
  2. NES_KC_BASE + NES_KC_REALM (org Actions variables)
  3. Hardcoded defaults (https://auth.herodevs.com/idp + universe)

Test plan

  • hd auth login completes successfully against prod (confirms
    auth.herodevs.com/idp OIDC endpoints are reachable)
  • Setting OAUTH_CONNECT_URL still overrides the URL (backwards
    compat)
  • Setting NES_KC_BASE + NES_KC_REALM constructs the expected
    realm URL

@v3nant v3nant marked this pull request as ready for review June 4, 2026 17:29
@v3nant v3nant requested a review from a team as a code owner June 4, 2026 17:29
@v3nant v3nant requested review from dannysauer and jtgorny June 4, 2026 17:29

@dannysauer dannysauer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks alright, but I'm probably not an appropriate codeowner. :)

@jtgorny

jtgorny commented Jun 4, 2026

Copy link
Copy Markdown

It looks right but that url won't be live until the 13th

@v3nant

v3nant commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

It looks right but that url won't be live until the 13th

got it, will be holding off the merge/deployment until then

@v3nant v3nant merged commit 6476b06 into main Jun 8, 2026
12 checks passed
@v3nant v3nant deleted the chore/migrate-kc-base-url branch June 8, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants