Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[The Magic Highlighter] Breaks .txt pages #36

Open
1 task done
badideasforsale opened this issue May 12, 2023 · 2 comments
Open
1 task done

[The Magic Highlighter] Breaks .txt pages #36

badideasforsale opened this issue May 12, 2023 · 2 comments
Labels
bug Something isn't working in progress We are actively working on this! TestFlight Available for testing in TestFlight

Comments

@badideasforsale
Copy link

Product

The Magic Highlighter

Subject

.txt pages are rendered white-on-white

Feedback

Hello!
If you load a .txt file in Safari, it seems The Magic Highlighter breaks the page by changing the text to be white. My system is set to Dark Mode.

initial view selected all text extension disabled

I can reproduce easily by disabling and reloading the file, then enabling. Safari auto-reloads the page for me. If I edit the generated HTML (which is a bit odd, considering it's a text file) and change background-color: rgb(255, 255, 255); to background-color: rgb(0, 0, 0); the text re-appears.

I'm hazarding a guess that the extension is injecting itself on a non-HTML resource, causing this issue; if that's correct, my expected behavior would be for The Magic Highlighter to not run if I'm not viewing a web page in the web browser. The next-best behavior would be to correctly set the background color to match the system setting.

Thanks!

Context

No response

Code of Conduct

  • I have read and agree to the Herd Works Product Feedback Issue Tracker project's Code of Conduct
@badideasforsale badideasforsale added the bug Something isn't working label May 12, 2023
@badideasforsale
Copy link
Author

If you load a .txt file in Safari, it seems The Magic Highlighter breaks the page by changing the text to be white. My system is set to Dark Mode.

Actually, now that I re-read my comment, I think The Magic Highlighter breaks the page by changing the background to be white. The text itself should be white when in Dark Mode to stand out against the background.

@calebhailey
Copy link
Member

Thanks for reporting! I suspect this is related to #21 which I have a fix for headed to TestFlight (pending review).

@calebhailey calebhailey added in progress We are actively working on this! TestFlight Available for testing in TestFlight labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress We are actively working on this! TestFlight Available for testing in TestFlight
Projects
None yet
Development

No branches or pull requests

2 participants