Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[The Magic Highlighter] Visited links styling is broken on Google searches #23

Open
1 task done
calebhailey opened this issue Apr 12, 2023 · 2 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@calebhailey
Copy link
Member

Product

The Magic Highlighter

Subject

Visited links styling is broken on Google searches

Feedback

A user recently reported this feedback:

The Magic Highlighter resets CSS on Google after visitng a link, they do not change color, it is nearly impossible for me to determine which result i already visited and which not, i tried to blacklist google.com and it resulted that the app didn't work with google anymore, can you please fix this?

I have also observed this behavior and will look into a remedy for an upcoming release.

Context

No response

Code of Conduct

  • I have read and agree to the Herd Works Product Feedback Issue Tracker project's Code of Conduct
@calebhailey calebhailey added the bug Something isn't working label Apr 12, 2023
@atoxx
Copy link

atoxx commented Apr 13, 2023

A brief look at the javascript code injected into Safari indicates the issue is related not to css but how !agicHighlighter opens links, the links are visited but the action is not forwarded to the browser so Sadari never puts the correct a.visted css rule on the link because MagicHighlighter intercepts the click and handles it itself

@atoxx
Copy link

atoxx commented Jun 20, 2023

any progress on this? this is very annoying right now, you never see where you already been

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants