Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor visibility map loading #65

Closed
ntessore opened this issue Nov 30, 2023 · 0 comments · Fixed by #66
Closed

Refactor visibility map loading #65

ntessore opened this issue Nov 30, 2023 · 0 comments · Fixed by #66
Assignees
@ntessore

Comments

@ntessore
Copy link
Contributor

This is a blocker for #59; before that issue can be resolved, the existing read_mask() functionality must be updated and decluttered.
@ntessore ntessore self-assigned this Nov 30, 2023
@ntessore ntessore mentioned this issue Nov 30, 2023
Merged
ntessore added a commit that referenced this issue Nov 30, 2023
@ntessore
ENH(io): refactor read_mask() into read_vmap() (#66)
1d05cd3 
Refactor the old `read_mask()` function into `read_vmap()`, which is
more in line with how we deal with visibility now.

Closes: #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntessore ntessore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH(io): refactor read_mask() into read_vmap() heracles-ec/heracles
1 participant
@ntessore