Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module name is not always the moduledir. #29

Open
ijsankar opened this issue May 14, 2021 · 7 comments
Open

Module name is not always the moduledir. #29

ijsankar opened this issue May 14, 2021 · 7 comments

Comments

@ijsankar
Copy link

Eg "allennlp-models" directory name is allennlp_models

@henon
Copy link
Owner

henon commented May 14, 2021

Please describe the problem in detail. Also, are you proposing a solution?

@ijsankar
Copy link
Author

If I have a module named scikit-learn installed. when I call IsModuleInstalled() it should return true. The function assumes that the module is in a folder named scikit-learn in site-packages folder. But the actual folder name is scikit_learn. Thus the function always returns false.

@henon
Copy link
Owner

henon commented May 14, 2021

I see. But how do we solve that problem?

@JimiC
Copy link

JimiC commented Jun 23, 2022

@henon The only way to resolve this is by looking into the site-packages folder and do a lookup to determine if scikit-learn or scikit_learn is present. Same issue happens with py-linq (https://pypi.org/project/py-linq/).

Alternatively the scikit_learn module name could be used but from my testing, in both cases (scikit-learn and scikit_learn), the corresponding folder is not present in the site-packages folder.

@henon
Copy link
Owner

henon commented Jun 23, 2022

So all we gotta do is check for either snake_case or kebab-case?

@JimiC
Copy link

JimiC commented Jun 23, 2022

So all we gotta do is check for either snake_case or kebab-case?

That seems to be the case with python library naming.

Maybe using a Regex would be more useful.

@JimiC
Copy link

JimiC commented Jun 23, 2022

Looking at it again I think that's something that pythonnet should resolve, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants