Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace empty .then() with .catch() and error logging #1100

Open
2 tasks
MaxSchaefer opened this issue Oct 1, 2024 · 0 comments · May be fixed by #1150
Open
2 tasks

Replace empty .then() with .catch() and error logging #1100

MaxSchaefer opened this issue Oct 1, 2024 · 0 comments · May be fixed by #1150
Assignees
@DasProffi
Labels
chore

Comments

@MaxSchaefer
Copy link
Member

Describe the chore

We have many empty .then()'s all around the place. We did this to satisfy our linter but we should use .catch() with error logging instead because an empty .then() omits every error that might be thrown.

  • Disallow empty .then() via the linter
  • Replace empty .then() with .catch() and error logging
@MaxSchaefer MaxSchaefer mentioned this issue Oct 1, 2024
Closed
@DasProffi DasProffi self-assigned this Dec 27, 2024
@DasProffi DasProffi linked a pull request Dec 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DasProffi DasProffi

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update linting helpwave/web
2 participants
@MaxSchaefer @DasProffi