Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: The "type" of rewards does not indicate the item awarded to the players #53

Open
raginmari opened this issue Aug 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@raginmari
Copy link
Contributor

raginmari commented Aug 18, 2024

Faulty File Path & Name

assignments/reward/type.json

Request information

The current major order has two different rewards: medals and requisition credits. Both rewards have type "1" while they differ in the "id32" item ID:

"rewards": [
    {
        "type": 1,
        "id32": 897894480,
        "amount": 45
    },
    {
        "type": 1,
        "id32": 3608481516,
        "amount": 29000
    }
]

So, the current assumption that "1" indicates the type of reward is wrong (see assignments/reward/type.json).

What is expected?

Hard to say: in the API, I would not expect an actual item ID to be used but a small set of reward type such as medals and requisitions. In this repository, I would probably expect the assignments/reward/type.json file to be removed?

What is actually happening?

See information above.

Any additional comments?

No response

@raginmari raginmari added the bug Something isn't working label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant