Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Include stratagem data #43

Open
ROBOT0-VT opened this issue Jun 1, 2024 · 6 comments
Open

[FEATURE]: Include stratagem data #43

ROBOT0-VT opened this issue Jun 1, 2024 · 6 comments

Comments

@ROBOT0-VT
Copy link

What problem is solved?

Being unable to access stratagem data

What is the solution?

Including a stratagems.json file with stratagem data, possibly under items

What value does this add?

Stratagem information is generally static between updates; so a static source of stratagem data, rather than an API such as https://github.com/hellhub-collective/api, would be perfect

Any additional comments?

No response

@Stonemercy
Copy link
Contributor

https://github.com/hellhub-collective/api/blob/main/src/static/json/stratagems.json

I'd be happy to contribute to upkeep if something like this was implemented

@ROBOT0-VT
Copy link
Author

I have a manually-compiled excel sheet that I converted to JSON, which is out of date, but contains more info (handy short names, Defensive/Offensive/Supply, how it's deployed and it's in-game listed attributes (e.g. explosive)).

If I cleaned that up, updated it and put it into a format similar to weapons (but as a JSON array, rather than an object, since I don't know the in-game IDs) would that be sufficient?

@ROBOT0-VT
Copy link
Author

ROBOT0-VT commented Jun 5, 2024

Here's the format I have it in currently, before cleanup:

[
  {
    "name":"Ballistic Shield Backpack",
    "short_name":"Ballistic Shield",
    "designation":"SH-20",
    "purpose":"Supply",
    "category":"Backpack",
    "traits":null,
    "code":"DLDDUL",
    "cooldown":300,
    "uses":null,
    "activation_time":5,
    "deployment":"Hellpod"
} ...

@dealloc
Copy link
Member

dealloc commented Jun 6, 2024

definitely sounds like something we could add, @chatterchats thoughts?

@chatterchats
Copy link
Collaborator

Something we could do, and something we've talked about before, however I believe the last time it was something along the lines of - It's not something that's reflected in the API. I'm not against adding it, however
@dealloc

@dealloc
Copy link
Member

dealloc commented Jun 24, 2024

if we can find a maintainable way of keeping the information up to date I don't mind too much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants