Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map PlanetEvent MaxHealth #45

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Map PlanetEvent MaxHealth #45

merged 1 commit into from
Apr 4, 2024

Conversation

lambstream
Copy link
Contributor

Closes #43

@lambstream lambstream self-assigned this Apr 4, 2024
@lambstream lambstream added the bug Something isn't working label Apr 4, 2024
@lambstream lambstream added this to the V1 milestone Apr 4, 2024
chatterchats
chatterchats reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@chatterchats chatterchats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @dealloc I'll leave final to you

@chatterchats chatterchats requested a review from dealloc April 4, 2024 19:02
@dealloc dealloc merged commit ac46f2a into master Apr 4, 2024
1 check passed
@dealloc dealloc deleted the bugfix-planetevent-maxhealth branch April 4, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatterchats chatterchats chatterchats left review comments

@dealloc dealloc dealloc approved these changes

Assignees

@lambstream lambstream

Labels
bug Something isn't working
Projects
None yet
Milestone
V1
Development

Successfully merging this pull request may close these issues.

[BUG] planet-events does not give event's maxHealth for planet
3 participants
@lambstream @dealloc @chatterchats