Ctrl key no longer works on when using Windows Command Prompt

[bootradev]

First occurs in commit 23553bd
It appears related to updating the crossterm dependency.

Reproduction steps

Ctrl doesn't work, observe trying to move using Ctrl-D or Ctrl-U, or trying to create a new split using Ctrl-W, Ctrl-V

Environment

• Platform: Windows
• Terminal emulator: Command Prompt
• Helix version: v0.5.0-463-g23553bd3

No output is written to helix.log

[bootradev]

Relevant issue: #677

[archseer]

\cc @superlou @WindSoilder

[superlou]

I'm trying to get the event-read example in crossterm running in the latest crossterm master, but I'm hitting build issues with wepoll. With crossterm 0.22 and the PR, I was definitely able to see ctrl at the crossterm level before.

[archseer]

@CptPotato Hey, sorry to ping you like this. You're running Windows, right? Could you test the crossterm example?

I'd like to determine if we broke crossterm or if this is a helix issue.

[WindSoilder]

Sorry for lately reply, I can reproduce this issue well, and I've verify that it works normally in crossterm 0.22..

I've verify event-read example, when I type ctrl-d, crossterm parse it as ctrl-D... which causes broken..

[archseer]

We need to double check crossterm-rs/crossterm#619 then

[CptPotato]

@CptPotato Hey, sorry to ping you like this. You're running Windows, right? Could you test the crossterm example?

I'd like to determine if we broke crossterm or if this is a helix issue.

No worries, happy to give it a shot:

Looks like I'm getting the same issue. Key bindings that use Ctrl don't work anymore in helix. As @WindSoilder also pointed out, running crossterm's event-read example shows upper case versions of the key pressed when using the Ctrl modifier, so it seems like a crossterm issue.

Note that not all keys behave like this. For example, Ctrl + m is interpreted as KeyEvent { code: Enter, modifiers: NONE }, Ctrl + 7 is KeyEvent { code: Char('_'), modifiers: SHIFT | CONTROL }, etc.

[superlou]

I'm on WIndows 10 Pro, 10.0.19044.
On the current crossterm master, for ctrl+m, I get: Event: Key(KeyEvent { code: Char('M'), modifiers: CONTROL })
Lowercase "m" by itself gives Event: Key(KeyEvent { code: Char('m'), modifiers: NONE }).

I have the same behavior on the original windows_key_logic branch, so I guess it wasn't something that showed up after our commits. @WindSoilder, sorry. I should have noticed this earlier.

[WindSoilder]

Sorry for introducing a new bug like this, I make a PR to fix this issue: crossterm-rs/crossterm#629

That pr simply convert from upper-case character to lower-case character

I've manually test it with helix, and it works fine for me.