Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.2 #2

Merged
merged 12 commits into from
Dec 15, 2023
Merged

v0.1.2 #2

merged 12 commits into from
Dec 15, 2023

Conversation

heitorpolidoro
Copy link
Owner

No description provided.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Tests

PR Summary: The pull request re-enables a set of tests related to issue comment events, specifically testing the creation and deletion of issue comments. The tests verify the correct instantiation of IssueCommentCreatedEvent and IssueCommentDeletedEvent objects and ensure that the events have the expected properties.

General suggestions:

  • Ensure that the tests cover all relevant aspects of the issue comment events, including edge cases and failure modes.
  • Consider adding more descriptive comments within the test cases to explain the purpose and expected outcomes, enhancing maintainability and readability for future contributors.
  • Verify that the tests are consistent with the project's testing conventions and that they integrate well with the existing test suite.

Your trial expires on December 20, 2023. Please email [email protected] to continue using Sourcery ✨

Copy link

codecov bot commented Dec 15, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@heitorpolidoro heitorpolidoro merged commit 3040d42 into master Dec 15, 2023
8 of 9 checks passed
@heitorpolidoro heitorpolidoro deleted the issue_comment branch December 15, 2023 18:16
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 4b839061
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4b83906) Report Missing Report Missing Report Missing
Head commit (03bc926) 101 91 90.10%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant