Add --quiet flag to suppress log spam #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppresses "Supervising n threads...", "Successfully made thread RT", and "Successfully demoted thread" messages.
13 tasks
| @@ -857,7 +865,7 @@ static void reset_known(void) { | |||
| if (verify_process_user(u, p) >= 0 && | |||
| verify_process_starttime(p) >= 0 && | |||
| verify_thread_starttime(p, t) >= 0) | |||
| if (thread_reset(t->pid) >= 0) { | |||
| if (thread_reset(t->pid) >= 0 && !log_quiet) { | |||
There was a problem hiding this comment.
The additional log_quiet check here may cause n_demoted++ to be erroneously skipped, affecting a log message which is still issued below:
syslog(LOG_NOTICE, "Demoted %u threads.\n", n_demoted)| @@ -951,7 +959,7 @@ static int reset_all(void) { | |||
|
|
|||
| if (r == SCHED_FIFO || r == SCHED_RR || | |||
| r == (SCHED_FIFO|SCHED_RESET_ON_FORK) || r == (SCHED_RR|SCHED_RESET_ON_FORK)) | |||
| if (thread_reset((pid_t) tid) >= 0) { | |||
| if (thread_reset((pid_t) tid) >= 0 && !log_quiet) { | |||
|
This PR has been open for almost a year. Is there anything preventing its merge? |
|
Alternative solution for |
|
Thanks, i'm also using the following, which eliminates the IMHO this setting, in the drop-in, should be shipped by default, which would eliminate the need for this PR 🖖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a --quiet flag to suppress log spam, fixing #22 (which has been noted by many others for the last decade). Specifically, it suppresses three types of messages:
"Supervising _ threads of _ processes of _ users."
"Successfully made thread _ of process _ owned by _ high priority at nice level _."
"Successfully demoted thread _ of process _."
These messages (especially the first two) are responsible for an annoyingly large amount of journal spam. It is convenient to have the ability to turn them off, but I have made no changes to the default behavior.