{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":273230449,"defaultBranch":"master","name":"gui","ownerLogin":"hebasto","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2020-06-18T12:20:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/32963518?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1723641818.0","currentOid":""},"activityList":{"items":[{"before":"cf0120ff024aa73a56f2975c832fda6aa8146dfa","after":"e43ce250c6fb65cc0c8903296c8ab228539d2204","ref":"refs/heads/master","pushedAt":"2024-09-13T10:51:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#835: Fix crash when closing wallet\n\na965f2bc07a3588f8c2b8d6a542961562e3f5d0e gui: fix crash when closing wallet (furszy)\n\nPull request description:\n\n The crash occurs because `WalletController::removeAndDeleteWallet` is called twice for the\n same wallet model: first in the GUI's button connected function `WalletController::closeWallet`,\n and then again when the backend emits the `WalletModel::unload` signal.\n\n This causes the issue because `removeAndDeleteWallet` inlines an `erase(std::remove())`.\n So, if `std::remove` returns an iterator to the end (indicating the element wasn't found\n because it was already erased), the subsequent call to `erase` leads to an undefined behavior.\n\n Test Notes:\n Try closing any wallet using the toolbar button in the GUI. It will crash in master, but not here.\n\n Fixes https://github.com/bitcoin/bitcoin/issues/30887.\n\nACKs for top commit:\n pablomartin4btc:\n tACK a965f2bc07a3588f8c2b8d6a542961562e3f5d0e\n jarolrod:\n ACK a965f2bc07a3588f8c2b8d6a542961562e3f5d0e\n hebasto:\n ACK a965f2bc07a3588f8c2b8d6a542961562e3f5d0e.\n\nTree-SHA512: c94681b95cb566f7aabd0d4fb10f797c2cea6ac569abc265e918f08e6abae3335432a0b0879372b54b2c109798ed0a4a249bf162c34add59cbd18d38a2d9660e","shortMessageHtmlLink":"Merge bitcoin-core#835: Fix crash when closing wallet"}},{"before":"d661e2b1b771abafb0b152842d775d3150032230","after":"cf0120ff024aa73a56f2975c832fda6aa8146dfa","ref":"refs/heads/master","pushedAt":"2024-09-13T08:46:13.000Z","pushType":"push","commitsCount":114,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30880: test: Wait for local services to update in feature_assumeutxo\n\n19f4a7c95a99162122068d4badffeea240967a65 test: Wait for local services to update in feature_assumeutxo (Fabian Jahr)\n\nPull request description:\n\n Closes #30878\n\n It seems like there is a race where the block is stored locally and `getblock` does not error anymore, but `ActivateBestChain` has not finished yet, so the local services are not updated yet either. Fix this by waiting for the local services to update.\n\n Can be reproduced locally by adding the sleep here:\n\n ```cpp\n ──────────────────────────────────────────────────────────────────────────────────────────────────────────┐\n src/validation.cpp:3567: bool Chainstate::ActivateBestChain(BlockValidationState& state, std::shared_ptr< │\n ──────────────────────────────────────────────────────────────────────────────────────────────────────────┘\n }\n\n if (WITH_LOCK(::cs_main, return m_disabled)) {\n std::this_thread::sleep_for(std::chrono::seconds(10));\n // Background chainstate has reached the snapshot base block, so exit.\n\n // Restart indexes to resume indexing for all blocks unique to the snapshot\n ```\n\nACKs for top commit:\n maflcko:\n review-only ACK 19f4a7c95a99162122068d4badffeea240967a65\n achow101:\n ACK 19f4a7c95a99162122068d4badffeea240967a65\n pablomartin4btc:\n tACK 19f4a7c95a99162122068d4badffeea240967a65\n furszy:\n Code review ACK [19f4a7c](https://github.com/bitcoin/bitcoin/pull/30880/commits/19f4a7c95a99162122068d4badffeea240967a65).\n\nTree-SHA512: 70dad3795988956c5e20f2d2d895fb56c5e3ce257c7547d3fd729c88949f0e24cb34594da1537bce8794ad02b2db44e7e46e995aa32539cd4dd84c4f1d4bb1c4","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30880: test: Wait for local services to update …"}},{"before":"d6a1b94ffdd845cd4886fd468f0e5910740eaf1d","after":"d661e2b1b771abafb0b152842d775d3150032230","ref":"refs/heads/master","pushedAt":"2024-09-05T17:56:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30812: lint: Check for release note snippets in the wrong folder\n\nfa3a7ebe5b5db63e4cb4fb6974c028cc7af0b898 lint: Check for release note snippets in the wrong folder (MarcoFalke)\n\nPull request description:\n\n It is a common mistake to place the snippets in the wrong folder, where they could be missed. For example https://github.com/bitcoin/bitcoin/pull/30719#pullrequestreview-2262535007 or commit 84900ac34f6888b7a851d0a6a5885192155f865c.\n\n Fix all issues by adding a simple lint check.\n\n Can be tested by reverting a prior commit that violated the rule and then running the new check:\n\n ```\n git revert 35ef34eab7b36e3c53ed438d74a9b783cbcaec27\n ( cd ./test/lint/test_runner/ && RUST_BACKTRACE=1 cargo run -- --lint=doc_release_note_snippets )\n\nACKs for top commit:\n l0rinc:\n ACK fa3a7ebe5b5db63e4cb4fb6974c028cc7af0b898\n TheCharlatan:\n Re-ACK fa3a7ebe5b5db63e4cb4fb6974c028cc7af0b898\n\nTree-SHA512: 65a13696178aa8f94daa12a767cc74861293c631c19da9ca23c0fd43cedd47e7928d0ef14ad9ad83a434c1ac0e006f5a632ba9679756e071dea65b3cbf927c2d","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30812: lint: Check for release note snippets in…"}},{"before":"6852d1d487a7da0dddfcc5d0bcad6d0d50c6b655","after":"d6a1b94ffdd845cd4886fd468f0e5910740eaf1d","ref":"refs/heads/master","pushedAt":"2024-09-05T13:29:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#834: qt, build: remove unneeded `Q_IMPORT_PLUGIN` macro calls\n\n7346b0109208c67798bdbd451e509048308eff5d qt, build: remove unneeded `Q_IMPORT_PLUGIN` macro calls (Sebastian Falbesoner)\n\nPull request description:\n\n After the recent full removal of Autotools (PR [#30664](https://github.com/bitcoin/bitcoin/pull/30664)), these macros are not needed anymore in the .cpp files according to the TODO in qt's CMakeLists.txt. Tested building on OpenBSD 7.5, where the XCB plugin was still imported according to the debug log:\n ```\n 2024-09-02T21:13:27Z Bitcoin Core version v28.99.0-7346b0109208 (release build)\n 2024-09-02T21:13:27Z Qt 5.15.12 (dynamic), plugin=xcb\n 2024-09-02T21:13:27Z No static plugins.\n 2024-09-02T21:13:27Z Style: fusion / QFusionStyle\n 2024-09-02T21:13:27Z System: OpenBSD 7.5, x86_64-little_endian-lp64\n ```\n\nACKs for top commit:\n hebasto:\n ACK 7346b0109208c67798bdbd451e509048308eff5d.\n\nTree-SHA512: ffa033fc6e0412a99d2c167044cc7af89512a731172d6911db71434f5353e811802c268d853a76d3732e9da954444cf6c39a852aeb25938c435826e117a16fca","shortMessageHtmlLink":"Merge bitcoin-core#834: qt, build: remove unneeded Q_IMPORT_PLUGIN …"}},{"before":"a74bdeea1b8e27b2335f0f7da78006e87ecfb235","after":"6852d1d487a7da0dddfcc5d0bcad6d0d50c6b655","ref":"refs/heads/master","pushedAt":"2024-09-05T13:25:51.000Z","pushType":"push","commitsCount":78,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30796: test: Use std::span and std::string_view for raw data\n\nfaecca9a85c1c1917d024f55cca34d19cc94f3b9 test: Use span for raw data (MarcoFalke)\nfac973647d69dd14089cee9972e8dfa0074c8a97 test: Use string_view for json_tests (MarcoFalke)\n\nPull request description:\n\n The build system converts raw data into a C++ header file for tests.\n\n This change modernizes the code to use the convenience wrappers `std::span` and `std::string_view`, so that redundant copies can be avoided.\n\nACKs for top commit:\n fjahr:\n re-ACK https://github.com/bitcoin/bitcoin/commit/faecca9a85c1c1917d024f55cca34d19cc94f3b9\n TheCharlatan:\n ACK faecca9a85c1c1917d024f55cca34d19cc94f3b9\n stickies-v:\n ACK faecca9a85c1c1917d024f55cca34d19cc94f3b9\n hebasto:\n ACK faecca9a85c1c1917d024f55cca34d19cc94f3b9, I have reviewed the code and the generated headers.\n\nTree-SHA512: 1f4951c54aff11ba27c41fb70f2821bdb79e06ca0abae734b970bd0d64dda9d8cced824a891fd51b3e9d4e5715ee9eb49ed5d369010a45eca7c3bec9f8641235","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30796: test: Use std::span and std::string_view…"}},{"before":"0a379a129b4a14fc6d286511f7509880d82f4ee5","after":"a74bdeea1b8e27b2335f0f7da78006e87ecfb235","ref":"refs/heads/master","pushedAt":"2024-09-02T23:14:24.000Z","pushType":"push","commitsCount":267,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30761: test: Avoid intermittent timeout in p2p_headers_sync_with_minchainwork.py\n\nfa247e6e8c7fddf9e3461c3e2e6f5fade0fe64cf test: Avoid intermittent timeout in p2p_headers_sync_with_minchainwork.py (MarcoFalke)\n\nPull request description:\n\n Similar to https://github.com/bitcoin/bitcoin/pull/30705:\n\n The goal of this test case is to check that the sync works at all, not to check any timeout.\n\n On extremely slow hardware (for example qemu virtual hardware), downloading the 4110 BLOCKS_TO_MINE may take longer than the block download timeout.\n\n Fix it by pinning the time using mocktime temporarily, and advance it immediately after the sync.\n\nACKs for top commit:\n stratospher:\n ACK fa247e6. Checked the timeout downloading block logs before/after using `setmocktime`.\n tdb3:\n ACK fa247e6e8c7fddf9e3461c3e2e6f5fade0fe64cf\n\nTree-SHA512: f61632a8d9e484f1b888aafbf87f7adf71b8692387bd77f603cdbc0de49f30d42e654741d46ae1ff8b9706a5559ee0faabdb192ed0db7449010b68bfcdbaa42d","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30761: test: Avoid intermittent timeout in p2p_…"}},{"before":"9264d62bd9e3d9bde0eea973393633d8b75e51a0","after":"0a379a129b4a14fc6d286511f7509880d82f4ee5","ref":"refs/heads/master","pushedAt":"2024-08-15T09:09:45.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28553: validation: assumeutxo params mainnet\n\n1610643c8b37a9f674b236cfa79abf8f8aaf1410 chainparams: add mainnet assumeutxo param at height 840_000 (Sjors Provoost)\n\nPull request description:\n\n This adds snapshot parameters for mainnet block 840,000.\n\n You can generate the snapshot yourself using `./contrib/devtools/utxo_snapshot.sh` or download my torrent:\n * torrent: `magnet:?xt=urn:btih:596c26cc709e213fdfec997183ff67067241440c&dn=utxo-840000.dat&tr=udp%3A%2F%2Ftracker.bitcoin.sprovoost.nl%3A6969`\n\n It would be a good idea to test:\n 1. That you can produce the same snapshot file, sha256 sum:\n\n ```\n dc4bb43d58d6a25e91eae93eb052d72e3318bd98ec62a5d0c11817cefbba177b utxo-840000.dat\n ```\n\n 2. That the snapshot works\n\nACKs for top commit:\n fjahr:\n re-ACK 1610643c8b37a9f674b236cfa79abf8f8aaf1410\n achow101:\n ACK 1610643c8b37a9f674b236cfa79abf8f8aaf1410\n theStack:\n Tested ACK 1610643c8b37a9f674b236cfa79abf8f8aaf1410\n mzumsande:\n tested ACK 1610643c8b37a9f674b236cfa79abf8f8aaf1410\n willcl-ark:\n tACK 1610643c8b37a9f674b236cfa79abf8f8aaf1410\n\nTree-SHA512: 581d8e86379bb044324f04f8559dd0a8946b6e2b145d5f25b38727b30b8cf13d6ac3c8777ff06554d3cf1a072809f7b5fbd693239868578f25dceafe5ba5f57c","shortMessageHtmlLink":"Merge bitcoin/bitcoin#28553: validation: assumeutxo params mainnet"}},{"before":"e682e7db7e399ce888e492eab8f99c389aae05b5","after":"9264d62bd9e3d9bde0eea973393633d8b75e51a0","ref":"refs/heads/master","pushedAt":"2024-08-14T14:22:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#833: Update translation source file for v28.0 string freeze\n\n770b0348c0abe2f63b56cc78c7b7a0e6b4057ce1 qt: Update translation source file for v28.0 string freeze (Hennadii Stepanov)\n\nPull request description:\n\n This PR updates the `src/qt/locale/bitcoin_en.xlf` translation source file according to the [Release schedule for 28.0](https://github.com/bitcoin/bitcoin/issues/29891).\n\n Note for reviewers: it is expected to get a zero diff after running `make -C src translate` locally.\n\nACKs for top commit:\n stickies-v:\n re-ACK 770b0348c0abe2f63b56cc78c7b7a0e6b4057ce1\n pablomartin4btc:\n re-ACK 770b0348c0abe2f63b56cc78c7b7a0e6b4057ce1\n\nTree-SHA512: 11dd26c470411aefc2e4f897c605162027a00e2a0ab1dcec9a1784c053349a3feaeedda7b649476ff528231801629e0ef342a48430ef54a4ec75ac1548c56d4f","shortMessageHtmlLink":"Merge bitcoin-core#833: Update translation source file for v28.0 stri…"}},{"before":"9edd8f300ca27cfabc310cbe015dc14160d24f1a","after":"770b0348c0abe2f63b56cc78c7b7a0e6b4057ce1","ref":"refs/heads/240813-tr","pushedAt":"2024-08-14T13:23:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"qt: Update translation source file for v28.0 string freeze\n\nThe diff is produced by running `make -C src translate`.","shortMessageHtmlLink":"qt: Update translation source file for v28.0 string freeze"}},{"before":"7583eac43ca87b383ce97dda9cf625d906efae23","after":"e682e7db7e399ce888e492eab8f99c389aae05b5","ref":"refs/heads/master","pushedAt":"2024-08-14T13:09:57.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#824: Migrate legacy wallets that are not loaded\n\n8f2522d242961ceb9e79672aa43e856863a1a6dd gui: Use menu for wallet migration (Ava Chow)\nd56a450bf5172e2c3f4b9a2786e71268019e1277 gui: Use wallet name for wallet migration rather than WalletModel (Ava Chow)\nc3918583dd5fcd9001136da2192e02e092128901 gui: don't remove wallet manually before migration (furszy)\nbfba63880fbb1108b73540faeb0620ba24b8cdd0 gui: Consolidate wallet display name to GUIUtil function (Ava Chow)\n28fc562f2692af4f37f918d4ae31c4d115e03aee wallet, interfaces: Include database format in listWalletDir (Ava Chow)\n\nPull request description:\n\n Currently the Migrate Wallet menu item can only be used to migrate the currently loaded wallet. This is not suitable for the future when legacy wallets can no longer be loaded at all, but should still be able to be migrated. This PR changes that menu item into a menu list like Open Wallet and lets users migrate any legacy wallet in their wallet directory regardless of the wallets loaded.\n\n One issue I ran into was dealing with encrypted wallets. Ideally, we would detect whether a wallet is encrypted, and prompt the user for their passphrase at that time. However, that's actually difficult to do in the GUI since migration will unload the wallet if it was already loaded, and reload it without connecting it to any signals or interfaces. Only then can it detect whether a wallet is encrypted, but then there is no `WalletModel` or even an `interfaces::Wallet` that the GUI could use to unlock it via a callback.\n\n To deal with this, I've opted to just add a button to the migration dialog box that has the user enter their passphrase first, along with instructional text to use that button if their wallet was encrypted. If the user enters the wrong passphrase or clicked the other button that does not prompt for the passphrase, migration will fail with a message indicating that the passphrase was incorrect.\n\nACKs for top commit:\n hebasto:\n ACK 8f2522d242961ceb9e79672aa43e856863a1a6dd.\n furszy:\n ACK 8f2522d\n\nTree-SHA512: a0e3b70dbfcacb89617956510ebcea94cad8617a987c68fe39fa16ac1721190b7cf7afc156c39b9032920cfb67b5d4ca28791681f5021d92d16acc691387afa1","shortMessageHtmlLink":"Merge bitcoin-core#824: Migrate legacy wallets that are not loaded"}},{"before":null,"after":"9edd8f300ca27cfabc310cbe015dc14160d24f1a","ref":"refs/heads/240813-tr","pushedAt":"2024-08-13T10:14:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"qt: Update translation source file for v28.0 string freeze\n\nThe diff is produced by running `make -C src translate`.","shortMessageHtmlLink":"qt: Update translation source file for v28.0 string freeze"}},{"before":"1873e4116ff53daacde7849f8b7f23ac0b527bec","after":"7583eac43ca87b383ce97dda9cf625d906efae23","ref":"refs/heads/master","pushedAt":"2024-08-13T09:41:15.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30617: net: Clarify that m_addr_local is only set once\n\nfa6fe432075df5e0eceb1ccd85038159cc820ccc net: Clarify that m_addr_local is only set once (MarcoFalke)\n\nPull request description:\n\n The function is supposed to be only called once when the version msg arrives (a single time). Calling it twice would be an internal logic bug. However, the `LogError` in this function has many issues:\n\n * If the error happens in tests, as is the case for the buggy fuzz test, it will go unnoticed\n * It is dead code, unless a bug is introduced to execute it\n\n Fix all issues by using `Assume(!m_addr_local.IsValid())` instead. Idea taken from https://github.com/bitcoin/bitcoin/pull/30364#discussion_r1680530382\n\nACKs for top commit:\n achow101:\n ACK fa6fe432075df5e0eceb1ccd85038159cc820ccc\n mzumsande:\n utACK fa6fe432075df5e0eceb1ccd85038159cc820ccc\n glozow:\n ACK fa6fe432075df5e0eceb1ccd85038159cc820ccc\n\nTree-SHA512: 8c1e8c524768f4f36cc50110ae54ee423e057a963ff78f736f3bf92df1ce5af28e3e0149153780897944e1d5c22ddbca9dac9865d9f4d44afffa152bc8559405","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30617: net: Clarify that m_addr_local is only s…"}},{"before":"42326b0fa46a67ad278cef7709a29feb05ce0110","after":"1873e4116ff53daacde7849f8b7f23ac0b527bec","ref":"refs/heads/master","pushedAt":"2024-08-12T16:19:19.000Z","pushType":"push","commitsCount":115,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#831: GUIUtil::brintToFront workaround for Wayland\n\n15aa7d023688700a47997b92108de95f2d864f5a gui, qt: brintToFront workaround for Wayland (pablomartin4btc)\n\nPull request description:\n\n There are known issues around handling windows focus in `Wayland` ([this one specific](https://bugs.kde.org/show_bug.cgi?id=462574) in KDE but also in [gnome](https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/730)).\n\n The idea is that the workaround will be executed if `bitcoin-qt` is running using `Wayland` platform (e.g.: `QT_QPA_PLATFORM=wayland ./src/qt/bitcoin-qt -regtest`), since the workaround behaviour looks like re-opening the window again (which I tried to fix by moving the window to the original position and/ or re-setting the original geometry without success) while in `X11` (not sure in Mac) the current `GUIUtil::brintToFront` actually sets the focus to the desired window, keeping its original position as expected, and I didn't want to change that (`X11` behaviour).\n\n The solution was [initially discussed](https://github.com/bitcoin-core/gui/pull/817#issuecomment-2256158902) with hebasto in #817.\n\nACKs for top commit:\n hebasto:\n ACK 15aa7d023688700a47997b92108de95f2d864f5a.\n\nTree-SHA512: 141d6cc4a618026e551627b9f4cc284285980db02a54a7b19c7de91e8c5adccf0c1d67380625146b5413e58c59f39c9e944ed5ba68cb8644f67647518918b6f7","shortMessageHtmlLink":"Merge bitcoin-core#831: GUIUtil::brintToFront workaround for Wayland"}},{"before":"eb85cacd2969caaea682104f498f6b2e6cfb80f8","after":"42326b0fa46a67ad278cef7709a29feb05ce0110","ref":"refs/heads/master","pushedAt":"2024-08-05T15:00:46.000Z","pushType":"push","commitsCount":30,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30512: net: Log accepted connection after m_nodes.push_back; Fix intermittent test issue\n\nfa3ea3b83c6a4c9726a17f2a48bbdb77f944bf6c test: Fix intermittent issue in p2p_v2_misbehaving.py (MarcoFalke)\n55555574d105f6c529c5c966c3c971c9db5ab786 net: Log accepted connection after m_nodes.push_back (MarcoFalke)\n\nPull request description:\n\n Fix the two issues reported in https://github.com/bitcoin/bitcoin/pull/30468/files#r1688444784:\n\n * Delay a debug log line for consistency.\n * Fix an intermittent test issue.\n\n They are completely separate fixes, but both `net` related.\n\nACKs for top commit:\n 0xB10C:\n Code Review ACK fa3ea3b83c6a4c9726a17f2a48bbdb77f944bf6c\n stratospher:\n tested ACK fa3ea3b.\n\nTree-SHA512: cd6b6e164b317058a305a5c3e38c56c9a814a7469039e1143f1d7addfbc91b0a28506873356b373d97448b46cb6fbe94a1309df82e34c855540b241a09489e8b","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30512: net: Log accepted connection after m_nod…"}},{"before":"2aff9a36c352640a263e8b5de469710f7e80eb54","after":"eb85cacd2969caaea682104f498f6b2e6cfb80f8","ref":"refs/heads/master","pushedAt":"2024-08-04T15:29:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#826: OptionsDialog: Allow Maximize of window\n\n3dbd94b6610a58460b52a6cc02892d881c091ccd GUI/OptionsDialog: Allow Maximize of window (Luke Dashjr)\n\nPull request description:\n\nACKs for top commit:\n hebasto:\n ACK 3dbd94b6610a58460b52a6cc02892d881c091ccd.\n\nTree-SHA512: 24a94840d97510ce5760c3099a765fb2f5d107d99a8f72757f509eefdaf35cb2d4d7f3243866bf6dc635fe83bb73b422e3cae2bd161d9b4b6f2e3d77bfd27353","shortMessageHtmlLink":"Merge bitcoin-core#826: OptionsDialog: Allow Maximize of window"}},{"before":"ec8b38c7b9d702382e08833ea23699951799055c","after":"2aff9a36c352640a263e8b5de469710f7e80eb54","ref":"refs/heads/master","pushedAt":"2024-08-02T22:05:47.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30352: policy: Add PayToAnchor(P2A), `OP_1 <0x4e73>` as a standard output script for spending\n\n75648cea5a9032b3d388cbebacb94d908e08924e test: add P2A ProduceSignature coverage (Greg Sanders)\n7998ce6b20fba62c022228355907b612ba6692e1 Add release note for P2A output feature (Greg Sanders)\n71c9b02a04742eeecab14aae4697b1a3eb51ff7f test: add P2A coverage for decodescript (Greg Sanders)\n1349e9ec1558484f2912a2444c410170fcec8745 test: Add anchor mempool acceptance test (Greg Sanders)\n9d892099378b2ad5f52220403bdeae43c61d6955 policy: stop 3rd party wtxid malleability of anchor spend (Greg Sanders)\nb60aaf8b239978947d2b0e3f56e7d8a4092d7570 policy: make anchor spend standard (Greg Sanders)\n455fca86cfada1823aa28615b5683f9dc73dbb9a policy: Add OP_1 <0x4e73> as a standard output type (Greg Sanders)\n\nPull request description:\n\n This is a sub-feature taken out of the original proposal for ephemeral anchors #30239\n\n This PR makes *spending* of `OP_1 <0x4e73>` (i.e. `bc1pfeessrawgf`) standard. Creation of this output type is already standard.\n\n Any future witness output types are considered relay-standard to create, but not to spend. This preserves upgrade hooks, such as a completely new output type for a softfork such as BIP341. It also gives us a bit of room to use a new output type for policy uses.\n\n This particular sized witness program has no other known use-cases (https://bitcoin.stackexchange.com/a/110664/17078), s it affords insufficient cryptographic security for a secure commitment to data, such as a script or a public key. This makes this type of output \"keyless\", or unauthenticated.\n\n As a witness program, the `scriptSig` of the input MUST be blank, by BIP141. This helps ensure txid-stability of the spending transaction, which may be required for smart contracting wallets. If we do not use segwit, a miner can simply insert an `OP_NOP` in the `scriptSig` without effecting the result of program execution.\n\n An additional relay restriction is to disallow non-empty witness data, which an adversary may use to penalize the \"honest\" transactor when RBF'ing the transaction due to the incremental fee requirement of RBF rules.\n\n The intended use-case for this output type is to \"anchor\" the transaction with a spending child to bring exogenous CPFP fees into the transaction package, encouraging the inclusion of the package in a block. The minimal size of creation and spending of this output makes it an attractive contrast to outputs like `p2sh(OP_TRUE)` and `p2wsh(OP_TRUE)` which\n are significantly larger in vbyte terms.\n\n Combined with TRUC transactions which limits the size of child transactions significantly, this is an attractive option for presigned transactions that need to be fee-bumped after the fact.\n\nACKs for top commit:\n sdaftuar:\n utACK 75648cea5a9032b3d388cbebacb94d908e08924e\n theStack:\n re-ACK 75648cea5a9032b3d388cbebacb94d908e08924e\n ismaelsadeeq:\n re-ACK 75648cea5a9032b3d388cbebacb94d908e08924e via [diff](https://github.com/bitcoin/bitcoin/compare/e7ce6dc070c0319cbb868d41cadd836b2e6ca9db..75648cea5a9032b3d388cbebacb94d908e08924e)\n glozow:\n ACK 75648cea5a9032b3d388cbebacb94d908e08924e\n tdb3:\n ACK 75648cea5a9032b3d388cbebacb94d908e08924e\n\nTree-SHA512: d529de23d20857e6cdb40fa611d0446b49989eaafed06c28280e8fd1897f1ed8d89a4eabbec1bbf8df3d319910066c3dbbba5a70a87ff0b2967d5205db32ad1e","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30352: policy: Add PayToAnchor(P2A), `OP_1 <0x4…"}},{"before":"b8755164cf9ce7159837d11d19065a5fd6d7d26d","after":"ec8b38c7b9d702382e08833ea23699951799055c","ref":"refs/heads/master","pushedAt":"2024-08-02T13:19:25.000Z","pushType":"push","commitsCount":24,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#626: Showing Local Addresses in Node Window\n\n189c987386a0da132d7ef076cdf539f9eb75fc3c Showing local addresses on the Node Window (Jadi)\na5d7aff867a3df9ac77664deed03e930e2636db0 net: Providing an interface for mapLocalHost (Jadi)\n\nPull request description:\n\n This change adds a new row to the Node Window (debugwindow.ui)\n under the Network section which shows the LocalAddresses.\n\n fixes #564\n\n \n\n \n\n \n\nACKs for top commit:\n pablomartin4btc:\n re-ACK 189c987386a0da132d7ef076cdf539f9eb75fc3c\n furszy:\n utACK 189c987\n\nTree-SHA512: 93f201bc6d21d81b27b87be050a447b841f01e3efb69b9eca2cc7af103023d7cd69eb5e16e2875855573ef51a5bf74a6ee6028636c1b6798cb4bb11567cb4996","shortMessageHtmlLink":"Merge bitcoin-core#626: Showing Local Addresses in Node Window"}},{"before":"d367a4e36f7357c4ebd018e8e1c9c5071db2e1c2","after":"b8755164cf9ce7159837d11d19065a5fd6d7d26d","ref":"refs/heads/master","pushedAt":"2024-08-01T09:59:58.000Z","pushType":"push","commitsCount":24,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30413: p2p: Lazy init some bloom filters; fuzz version handshake\n\nafd237bb5d85923273a69f7b45dc6aae6aa1680e [fuzz] Harness for version handshake (dergoegge)\na90ab4aec9cccd44d867842d6a1161d5758fcb2c scripted-diff: Rename lazily initialized bloom filters (dergoegge)\n82de1bc478d54bea6125b459febfb2fb23929c61 [net processing] Lazily initialize m_recent_confirmed_transactions (dergoegge)\nfa0c87f19c1eca47ee7052f3c988ff7273801ff3 [net processing] Lazily initialize m_recent_rejects_reconsiderable (dergoegge)\n662e8db2d3efc651951315b295952a2eebb822cd [net processing] Lazily initialize m_recent_rejects (dergoegge)\n\nPull request description:\n\n This adds a fuzzing harness dedicated to the version handshake. To avoid determinism issues, the harness creates necessary components each iteration (addrman, peerman, etc). A harness like this would have easily caught https://bitcoincore.org/en/2024/07/03/disclose-timestamp-overflow/.\n\n As a performance optimization, this PR includes a change to `PeerManager` to lazily initialize various filters (to avoid large unnecessary memory allocations each iteration).\n\nACKs for top commit:\n brunoerg:\n ACK afd237bb5d85923273a69f7b45dc6aae6aa1680e\n marcofleon:\n Tested ACK afd237bb5d85923273a69f7b45dc6aae6aa1680e. I compared the coverage of `net_processing` from this harness to the `process_message` and `process_messages` harnesses to see the differences. This target hits more specific parts of the version handshake. The stability looks good as well, at about 94%.\n glozow:\n utACK afd237bb5d85923273a69f7b45dc6aae6aa1680e lazy blooms look ok\n mzumsande:\n Code Review ACK afd237bb5d85923273a69f7b45dc6aae6aa1680e\n\nTree-SHA512: 62bba20aec0cd220e62368354891f9790b81ad75e8adf7b22a76a6d4663bd26aedc4cae8083658a75ea9043d60aad3f0e58ad36bd7bbbf93ff1d16e317bf15cc","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30413: p2p: Lazy init some bloom filters; fuzz …"}},{"before":"f66738f79c79eb00332e64d0841937b7a1f2db0b","after":"d367a4e36f7357c4ebd018e8e1c9c5071db2e1c2","ref":"refs/heads/master","pushedAt":"2024-07-30T16:57:16.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#505: Hide peers details\n\n41a1a8615dd48fdd9811b9824c49ceb934c6375e gui: Hide peers details (@RandyMcMillan)\n\nPull request description:\n\n Add a close (X) button to the Peers Detail panel.\n Reuse the same icon used in the Console Tab.\n The close button deselects the peer highlighted\n in the PeerTableView and hides the detail panel.\n\n fixes #485\n\n Co-authored-by: @w0xlt \n\nACKs for top commit:\n pablomartin4btc:\n re ACK 41a1a8615dd48fdd9811b9824c49ceb934c6375e\n hebasto:\n ACK 41a1a8615dd48fdd9811b9824c49ceb934c6375e, tested on Ubuntu 23.10.\n\nTree-SHA512: fc692891eec61bd1e6878f2433b478de3c69bf0b3ce3471f2faafda6f63d371e2cc125ae8290fd2ac3e4d8659031b79d85665318cfc5a9481e967ef99d245f9c","shortMessageHtmlLink":"Merge bitcoin-core#505: Hide peers details"}},{"before":"c9b7a792e2d8cfe5be14829ee6108d24abf8fcf6","after":"f66738f79c79eb00332e64d0841937b7a1f2db0b","ref":"refs/heads/master","pushedAt":"2024-07-30T09:20:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30542: ci: enable berkley db on test each commit job\n\n93ee17c1d610f811e86fcf17db00df24f7de8c1b ci: enable berkley db on test each commit job (Max Edwards)\n\nPull request description:\n\n As the \"test each commit\" job installs `libdb++-dev` it looks like it was intended that it would compile with Berkeley DB support.\n\n This PR enables it.\n\n CI run log with the change: https://github.com/m3dwards/bitcoin/actions/runs/10142921800/job/28043223197?pr=1\n\nACKs for top commit:\n maflcko:\n ACK 93ee17c1d610f811e86fcf17db00df24f7de8c1b\n danielabrozzoni:\n ACK 93ee17c1d610f811e86fcf17db00df24f7de8c1b\n hebasto:\n ACK 93ee17c1d610f811e86fcf17db00df24f7de8c1b.\n\nTree-SHA512: b6c2a7cea104a84221814fd121fd4fef2d7c0c3717f8c3fe35ec3c42e850e72085e9e6407b61ca1f9e86571346fa33a2cdd924210b26155956835011775320b2","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30542: ci: enable berkley db on test each commi…"}},{"before":"7cc00bfc86b4dece2e3baef5b12e910d79c822a1","after":"c9b7a792e2d8cfe5be14829ee6108d24abf8fcf6","ref":"refs/heads/master","pushedAt":"2024-07-29T09:34:13.000Z","pushType":"push","commitsCount":86,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#828: Rendering an amp characters in the wallet name for QMenu\n\n8233ee41ab9648cd0c3bd78bc2a8d692a54d9ea0 gui: correct replacement of amp character in the wallet name for QMenu (Konstantin Akimov)\n\nPull request description:\n\n In the current implementation Qt uses '&' as a signal to underscore letter and use it as a hot-key, which is not expected for case of wallet name.\n\n The [comment in the code](https://github.com/bitcoin/bitcoin/pull/30446/files#diff-2ecf8cbf369cf3d2f3d2b1cf5cfe4c1a647d63e11e2885d2fd0ac11fb5f7a804L402-L404) regarding the use of an \"&\" on a menu item is misleading.\n If a wallet name has an \"&\" in it, it is not supposed to be interpreted as a hot-key, but it should be shown as it is without replacing it to an underscore.\n\n See screenshots before & after:\n \n \n\nACKs for top commit:\n hebasto:\n re-ACK 8233ee41ab9648cd0c3bd78bc2a8d692a54d9ea0.\n pablomartin4btc:\n tACK 8233ee41ab9648cd0c3bd78bc2a8d692a54d9ea0\n BrandonOdiwuor:\n ACK 8233ee41ab9648cd0c3bd78bc2a8d692a54d9ea0. Tested on Ubuntu 22.04 using Qt version 5.15.3\n\nTree-SHA512: 918c2c05555d203a8b203794c138651d4a1691a05a858631d5a4664b78e150402d1ae4a02ee5181f63a5b22a09badca0a4ea14a626f45f8cbe557226c308b8c5","shortMessageHtmlLink":"Merge bitcoin-core#828: Rendering an amp characters in the wallet nam…"}},{"before":"84063a4c4c0a5c8e39de1500b835c3a318eea089","after":"7cc00bfc86b4dece2e3baef5b12e910d79c822a1","ref":"refs/heads/master","pushedAt":"2024-07-24T07:57:31.000Z","pushType":"push","commitsCount":119,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30436: fix: Make TxidFromString() respect string_view length\n\n09ce3501fa2ea2885a857e380eddb74605f7038c fix: Make TxidFromString() respect string_view length (Hodlinator)\n01e314ce0ae30228742b6f19d2f12a050ab97e4d refactor: Change base_blob::SetHex() to take std::string_view (Hodlinator)\n2f5577dc2e7ba668798a89a2f6ef72795db6c285 test: uint256 - Garbage suffixes and zero padding (Hodlinator)\nf11f816800ac520064a1e96871d0b4cc9601ced7 refactor: Make uint256_tests no longer use deprecated BOOST_CHECK() (Hodlinator)\nf0eeee2dc1329b0647df09bea9ccc0395bb82698 test: Add test for TxidFromString() behavior (Ryan Ofsky)\n\nPull request description:\n\n ### Problem\n\n Prior to this, `TxidFromString()` was passing `string_view::data()` into `uint256S()` which meant it would only receive the a naked `char*` pointer and potentially scan past the `string_view::length()` until it found a null terminator (or some other non-hex character).\n\n Appears to have been a fully dormant bug as callers were either passing a string literal or `std::string` directly to `TxidFromFromString()`, meaning a null terminator always existed at `pointer[length()]`. Bug existed since original merge of `TxidFromString()`.\n\n ### Solution\n\n Make `uint256S()` (and `base_blob::SetHex()`) take and operate on `std::string_view` instead of `const char*` and have `TxidFromString()` pass that in.\n\n (PR was prompted by comment in https://github.com/bitcoin/bitcoin/pull/30377#issuecomment-2208857200 (referring to https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1404437378)).\n\nACKs for top commit:\n maflcko:\n re-ACK 09ce3501fa2ea2885a857e380eddb74605f7038c 🕓\n paplorinc:\n ACK 09ce3501fa2ea2885a857e380eddb74605f7038c\n ryanofsky:\n Code review ACK 09ce3501fa2ea2885a857e380eddb74605f7038c. I think the current code changes are about as small as you could make to fix the bug without introducing a string copy, and the surrounding test improvements are all very nice and welcome.\n\nTree-SHA512: c2c10551785fb6688d1e2492ba42a8eee4c19abbe8461bb0774d56a70c23cd6b0718d2641632890bee880c06202dee148126447dd2264eaed4f5fee7e1bcb581","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30436: fix: Make TxidFromString() respect strin…"}},{"before":"6ae903e24afa95214e59a9dc87dc74db3535a5b5","after":"84063a4c4c0a5c8e39de1500b835c3a318eea089","ref":"refs/heads/master","pushedAt":"2024-07-15T11:15:51.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#827: OptionsDialog: Prefer to stretch actual options area rather than waste space\n\nb71bfd9eef8b0017cef3c05361c02ddbd837e6ac GUI/OptionsDialog: Prefer to stretch actual options area rather than waste space (Luke Dashjr)\n\nPull request description:\n\nACKs for top commit:\n hebasto:\n ACK b71bfd9eef8b0017cef3c05361c02ddbd837e6ac\n\nTree-SHA512: b706a07292fe81379e303f9069fca6efd5ceb15ee5bb77c6aeddbf63f736494ce877b76767ff17d7becf98d07209e51c74bdb99365596b7b9f4904a30438d72d","shortMessageHtmlLink":"Merge bitcoin-core#827: OptionsDialog: Prefer to stretch actual optio…"}},{"before":"ff100bb549f21dc0136af9241fd2de6daffb19a2","after":"6ae903e24afa95214e59a9dc87dc74db3535a5b5","ref":"refs/heads/master","pushedAt":"2024-07-15T09:47:48.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#795: Keep focus on \"Hide\" while ModalOverlay is visible\n\n992b1bbd5da95ee782515fb0f5674bb7a02684b2 qt: keep focus on \"Hide\" while ModalOverlay is visible (Jadi)\n\nPull request description:\n\n During the initial sync, the Tab moves the focus to the widgets of the main window, even when the ModalOverlay is visible. This creates some weird rectangular *selections on the screen*.\n\n This PR fixes this by keeping the focus on the \"Hide\" button while the ModalOverlay is visible.\n\n Fixes #783\n\nACKs for top commit:\n pablomartin4btc:\n Concept & approach ACK 992b1bbd5da95ee782515fb0f5674bb7a02684b2\n hebasto:\n re-ACK 992b1bbd5da95ee782515fb0f5674bb7a02684b2\n\nTree-SHA512: f702a3fd51db4bc10780bccf76394e35a6b5fb45db72c9c23cd10d777106b08c61077d2d989003838921e76d2cb44f809399f31df76448e4305a6c2a71b5c6a3","shortMessageHtmlLink":"Merge bitcoin-core#795: Keep focus on \"Hide\" while ModalOverlay is vi…"}},{"before":"c4d45b695ef27e21d35e886b08887e2ecf272ce7","after":"ff100bb549f21dc0136af9241fd2de6daffb19a2","ref":"refs/heads/master","pushedAt":"2024-07-14T12:08:44.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#825: Show maximum mempool size in information window\n\n4a028cf54c0502bc9ba0804bf1ae413b20a007cb gui: show maximum mempool size in information window (Sebastian Falbesoner)\nbbde6ffefea9587b07a9f8d4043b2dd23ef8c3c5 add node interface method for getting maximum mempool size (Sebastian Falbesoner)\n\nPull request description:\n\n This PR adds the maximum mempool size to the information window (Menu \"Window\" -> \"Information\" -> section \"Memory Pool\" -> line \"Memory usage\").\n\n master:\n\n \n\n PR:\n\n \n\nACKs for top commit:\n MarnixCroes:\n tested ACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb\n pablomartin4btc:\n tACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb\n luke-jr:\n tACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb & in Knots\n hebasto:\n ACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb, tested on Ubuntu 24.04.\n\nTree-SHA512: c10fb23605d060cea19a86d11822fc4d12496b19547870052aace503670e62e4c4e19ae4c2c4fbf7420a472adb071c9ddebe82447e0cfbce5a6fb9fcd7b9eda3","shortMessageHtmlLink":"Merge bitcoin-core#825: Show maximum mempool size in information window"}},{"before":"9b480f7a25a737c9c4ebc33401e94d66c2da9ec3","after":"c4d45b695ef27e21d35e886b08887e2ecf272ce7","ref":"refs/heads/master","pushedAt":"2024-07-14T10:09:20.000Z","pushType":"push","commitsCount":31,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30295: #28984 package rbf followups\n\n3f00aae14092ca076cff7f9ddf6155c601979fcd package rbf: cpfp structure requires package > parent feerate (Greg Sanders)\nad7f1f697f01845470f8df0944a94012fabcba09 test package rbf boundary conditions more closely (Greg Sanders)\nff4558d441f377a372647972d35b5476b94579c9 doc: reword package RBF documentation (Greg Sanders)\nde669a883bf65c576cc596b20a576d7bb1618182 doc: replace mention of V3 with TRUC (Greg Sanders)\n\nPull request description:\n\n Some suggested nits/changes from #28984\n\nACKs for top commit:\n glozow:\n ACK 3f00aae1409\n murchandamus:\n ACK 3f00aae14092ca076cff7f9ddf6155c601979fcd\n\nTree-SHA512: 79434cc8aba25a43e99793298cdc99cad807db2c3a2e780a31953f244b95eecd97b90559abd67fbf30996c00966675fa257253a7812ec4727420226162c629ae","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30295: #28984 package rbf followups"}},{"before":"2c79abc7ad4850e9e3ba32a04c530155cda7f980","after":"9b480f7a25a737c9c4ebc33401e94d66c2da9ec3","ref":"refs/heads/master","pushedAt":"2024-07-11T10:29:29.000Z","pushType":"push","commitsCount":243,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30414: [doc] archive v26.2 release notes\n\n3c61cf3986d40ce0eae794f8a9571247f8af99e4 [doc] archive v26.2 release notes (glozow)\n\nPull request description:\n\n To create the github release\n\nACKs for top commit:\n achow101:\n ACK 3c61cf3986d40ce0eae794f8a9571247f8af99e4\n stickies-v:\n ACK 3c61cf3986d40ce0eae794f8a9571247f8af99e4\n\nTree-SHA512: 70c316c68f73baae4abf4e5c8999620a7d7aa869a1dd51a4f72dc9093f24a52916249ee460648fe82bc6c1e5d568b9dca185b10b8faa86b499d84e30c65be3fa","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30414: [doc] archive v26.2 release notes"}},{"before":"a44b0f771f2130b89b608f39055a355693c91a8c","after":"2c79abc7ad4850e9e3ba32a04c530155cda7f980","ref":"refs/heads/master","pushedAt":"2024-06-16T08:04:54.000Z","pushType":"push","commitsCount":95,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#27969: bumpfee: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee_rate\n\nf58beabe754363cb7d5b24032fd392654b9514ac test: bumpfee with user specified fee_rate ignores walletIncrementalRelayFee (ismaelsadeeq)\n436e88f4336199998184cbfa5d1c889ffaefbfb5 bumpfee: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee rate (ismaelsadeeq)\n\nPull request description:\n\n Fixes #26973\n\n When using the `bumpfee` RPC and manually specifying `fee_rate`, there should be no requirement that the new fee must be at least the sum of the original fee and `incrementalFee` (maximum of `relayIncrementalFee` and `WALLET_INCREMENTAL_RELAY_FEE`).\n\n This restriction should only apply when user did not specify `fee_rate`.\n > because the GUI doesn't let the user specify the new fee rate yet (https://github.com/bitcoin-core/gui/issues/647), it would be very annoying to have to bump 20 times to increment by 20 sat/vbyte.\n\n The restriction should instead be the new fee must be at least the sum of the original fee and `incrementalFee` (`relayIncrementalFee`)\n\nACKs for top commit:\n achow101:\n ACK f58beabe754363cb7d5b24032fd392654b9514ac\n murchandamus:\n ACK f58beabe754363cb7d5b24032fd392654b9514ac\n\nTree-SHA512: 193259f87173b7d5a8e68e0e29f2ca7e75c550e3cf0dee3d6d822b5b1e07c2e6dec0bfc8fb435855736ebced97a10dbdbfef72e8c5abde06fdefcba122f2e7f1","shortMessageHtmlLink":"Merge bitcoin/bitcoin#27969: bumpfee: ignore WALLET_INCREMENTAL_RELAY…"}},{"before":"457e1846d2bf6ef9d54b9ba1a330ba8bbff13091","after":"a44b0f771f2130b89b608f39055a355693c91a8c","ref":"refs/heads/master","pushedAt":"2024-06-09T11:41:56.000Z","pushType":"push","commitsCount":85,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30238: json-rpc 2.0 followups: docs, tests, cli\n\n1f6ab1215bbb1f8a5f1743c3c413b95ad08090df minor: remove unnecessary semicolons from RPC content type examples (Matthew Zipkin)\nb22529529823c0cb5916ac318c8536e9107b7e78 test: use json-rpc 2.0 in all functional tests by default (Matthew Zipkin)\n391843b0297db03d71a8d88ab77609e2ad230bf2 bitcoin-cli: use json-rpc 2.0 (Matthew Zipkin)\nd39bdf339772166a5545ae811e58b7764af093a8 test: remove unused variable in interface_rpc.py (Matthew Zipkin)\n0ead71df8c83a2f9eae1220544ec84dcf38a0326 doc: update and link for JSON-RPC 2.0 (Matthew Zipkin)\n\nPull request description:\n\n This is a follow-up to #27101.\n\n - Addresses [post-merge comments ](https://github.com/bitcoin/bitcoin/pull/27101#discussion_r1606723428)\n - bitcoin-cli uses JSON-RPC 2.0\n - functional tests use JSON-RPC 2.0 by default (exceptions are in the regression tests added by #27101)\n\nACKs for top commit:\n tdb3:\n ACK 1f6ab1215bbb1f8a5f1743c3c413b95ad08090df\n cbergqvist:\n ACK 1f6ab1215bbb1f8a5f1743c3c413b95ad08090df\n\nTree-SHA512: 49bf14c70464081280216ece538a2f5ec810bac80a86a83ad3284f0f1b017edf755a1a74a45be279effe00218170cafde7c2de58aed07097a95c2c6b837a6b6c","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30238: json-rpc 2.0 followups: docs, tests, cli"}},{"before":"a786fd2041913d82ca90b561de309421bd24e41b","after":"457e1846d2bf6ef9d54b9ba1a330ba8bbff13091","ref":"refs/heads/master","pushedAt":"2024-06-03T08:03:08.000Z","pushType":"push","commitsCount":76,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30204: depends: consolidate dependency docs\n\na27e1ceb9f9c9239af9b0a151c84a57573ea646a depends: consolidate dependency docs (fanquake)\n\nPull request description:\n\n Adds missing `g++` for macOS. This is needed by Qt:\n ```bash\n Configuring qt...\n Creating qmake...\n gmake[1]: Entering directory '/bitcoin/depends/work/build/arm64-apple-darwin/qt/5.15.14-4bca24c8f89/qtbase/qmake'\n gmake[1]: g++: No such file or directory\n gmake[1]: *** [Makefile:250: main.o] Error 127\n ```\n\n `xz-utils` was also missing (but generally already installed), and is needed for the `.tar.xz` tarballs.\n\n Remove `bsdmainutils`, as this is only needed by the main build system (for tests), and isn't needed to complete a depends build.\n\nACKs for top commit:\n maflcko:\n ACK a27e1ceb9f9c9239af9b0a151c84a57573ea646a\n\nTree-SHA512: 720c31d4d4c9b86fda4aace405d528193714dd3e526f38d5b8a83e4b676a433b9c891f01d86d673be9ac848458eda8a89b0981003a42eaa6d97bacc2e914396a","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30204: depends: consolidate dependency docs"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxMDo1MTowOC4wMDAwMDBazwAAAAS1YEo0","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxMDo1MTowOC4wMDAwMDBazwAAAAS1YEo0","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNi0wM1QwODowMzowOC4wMDAwMDBazwAAAARaqqAG"}},"title":"Activity · hebasto/gui"}