{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":373540372,"defaultBranch":"main","name":"gui-qml","ownerLogin":"hebasto","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-06-03T14:40:38.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/32963518?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717874048.0","currentOid":""},"activityList":{"items":[{"before":"b979bdc88834a49a9ec5a01d82ec21c466b5657b","after":"84c4372b67cd3729f9a214ddb0d58770aec3abff","ref":"refs/heads/main","pushedAt":"2024-09-11T09:00:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#416: add scrollbar to wallet select list\n\nba98b833ee64d91ef0aa53f9ff4d775f9558df8a qml: add scrollbar to wallet select list (Marnix)\n\nPull request description:\n\n This adds a scrollbar to the wallet selection list.\n\n Addresses https://github.com/bitcoin-core/gui-qml/pull/401#pullrequestreview-2229526807\n\n ---\n\n ### Images\n\n scrollbar visible on hover/when scrolling when having more wallets than that are initially visible\n ![image](https://github.com/user-attachments/assets/6cecd990-5e20-48d7-95eb-fcf79cd368d6)\n\n no scrollbar when not needed:\n ![image](https://github.com/user-attachments/assets/1d9d7418-858a-4576-a1fc-c63ead211919)\n\n \n\n \n\n \n\n \n\nACKs for top commit:\n pablomartin4btc:\n utACK ba98b833ee64d91ef0aa53f9ff4d775f9558df8a\n jarolrod:\n ACK ba98b833ee64d91ef0aa53f9ff4d775f9558df8a\n\nTree-SHA512: 1013230070913dcb2be6674b9c25acc51c49b8e603b079ca6e6802b3d6b6ce7fabca44a25bef1f641c133b75051d132200573e3d5846c59beb14bcff5edbd34c","shortMessageHtmlLink":"Merge bitcoin-core#416: add scrollbar to wallet select list"}},{"before":"48bc2c85b56ccef38739cfc9141eaf9dbc3851f0","after":"b979bdc88834a49a9ec5a01d82ec21c466b5657b","ref":"refs/heads/main","pushedAt":"2024-09-06T20:13:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#383: Put BlockClock into an error state if node init fails\n\n2b61d228859af296a64f47977953f51cbedc42fc qml: Put BlockClock into an Error state if init fails (johnny9)\n\nPull request description:\n\n Initial step for adding error states to the NodeRunner\n\n Link to github actions build artifacts.\n\n [![Build Artifacts](https://img.shields.io/badge/Build%20Artifacts-green\n )]()\n\nACKs for top commit:\n pablomartin4btc:\n tACK 2b61d228859af296a64f47977953f51cbedc42fc\n MarnixCroes:\n tACK 2b61d228859af296a64f47977953f51cbedc42fc\n\nTree-SHA512: 5da6e8cde6e7d24dbd1adffa8014622e188e5ec1abc17b260ba696239c5cc7558a57c6650336549ccfb715cc17fb2b72f28dc107d86e3a21f46f307357525ac7","shortMessageHtmlLink":"Merge bitcoin-core#383: Put BlockClock into an error state if node in…"}},{"before":"e7bea2d9373764427878531b66e246c4ba94235f","after":"48bc2c85b56ccef38739cfc9141eaf9dbc3851f0","ref":"refs/heads/main","pushedAt":"2024-09-02T14:29:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#420: Wallet creation flow font weight and color tweaks\n\nc753d16268eb6bf241742bada63546d46489d80a Wallet creation flow font weight and color tweaks (GBKS)\n\nPull request description:\n\n There are some very minor implementation discrepancies from the design in the wallet creation flow. The font weights for several titles are regular, but should be semi-bold (see all the other screens in the onboarding flow for examples). Two divider lines are neutral 7, but should be the neutral 4 color.\n\n See the following image with screenshots for the comparison. Top row shows the before, the bottom row shows the after. The second column is where the two divider line colors were adjusted. The other columns is where the font weight of the header was adjusted.\n\n ![image](https://github.com/user-attachments/assets/173955a9-438a-43b0-b5f7-9b23955b7286)\n\n This is my first PR for this project, let me know what I am doing wrong.\n\nACKs for top commit:\n MarnixCroes:\n lgtm ACK c753d16268eb6bf241742bada63546d46489d80a\n pablomartin4btc:\n utACK c753d16268eb6bf241742bada63546d46489d80a\n\nTree-SHA512: a26163620eb37712fb72811d2ce363bad025a2884d30abf03fc96e32b7fed04486f75be01f52120d42d8f0bf89aeb8551783b17bef75004af692fe742275a885","shortMessageHtmlLink":"Merge bitcoin-core#420: Wallet creation flow font weight and color tw…"}},{"before":"a85fc8f32ae73943a88d9a3759c03e85f9d35a43","after":"e7bea2d9373764427878531b66e246c4ba94235f","ref":"refs/heads/main","pushedAt":"2024-08-12T10:19:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#414: Uncomment DebugMessageHandler install\n\n456d28a63992aa3916c7c2d30aeb0050db7ccd7c qml: uncomment DebugMessageHandler install (johnny9)\n\nPull request description:\n\n DebugMessageHandler is needed to route output to debug.log and should not have been commented out.\n\n Mistakenly commented out in https://github.com/bitcoin-core/gui-qml/pull/403\n\nACKs for top commit:\n MarnixCroes:\n ACK 456d28a63992aa3916c7c2d30aeb0050db7ccd7c\n hebasto:\n ACK 456d28a63992aa3916c7c2d30aeb0050db7ccd7c\n\nTree-SHA512: c78e526deccba366854287c796e2ac4843f1aba7b936d6955b6ec2212e75fac6a4372e3994e4045a45e083c7422fb827fddb674c64a593affa1226589f14d8ab","shortMessageHtmlLink":"Merge bitcoin-core#414: Uncomment DebugMessageHandler install"}},{"before":"8c191226cec61021ab6cb5bb409b9a70c44b527f","after":"a85fc8f32ae73943a88d9a3759c03e85f9d35a43","ref":"refs/heads/main","pushedAt":"2024-08-12T10:15:02.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#410: create wallet: set focus on TextField so it is automatically selected\n\n0beac80087f6143e9ef846026f2eb8aa22c1852c qml: create wallet: set focus on TextField (Marnix)\n\nPull request description:\n\n add `focus: true` to make it automatically selected so user doesn't have to first manually select it before it can type something\n\n addresses https://github.com/bitcoin-core/gui-qml/pull/403#pullrequestreview-2082083987\n\nACKs for top commit:\n johnny9:\n tACK 0beac80087f6143e9ef846026f2eb8aa22c1852c\n\nTree-SHA512: 61430831010dbd582176e9fd57ec7dcafbc5c705ee7ede7d7d33bc5d49e76340d4d233de385f2b59fc8c27d4422d3d82c30238678a5ee1429f7659800e6820b0","shortMessageHtmlLink":"Merge bitcoin-core#410: create wallet: set focus on TextField so it i…"}},{"before":"a73577b7b79d541472a80471a6adcadebe6d9deb","after":"8c191226cec61021ab6cb5bb409b9a70c44b527f","ref":"refs/heads/main","pushedAt":"2024-08-12T10:04:56.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#401: Introduce Wallet Select Dropdown\n\n0939f2bfd7586c04ad35aabffc5028511c1a236f qml: Introduce the WalletSelect component (johnny9)\n5906e69bc13b0e7607a7fae7fa6e97ff624dc887 qml: Introduce the WalletBadge component (johnny9)\n\nPull request description:\n\n WalletSelect is a Popup that appears after clicking the main\n WalletBadge in the DesktopNavigation bar. It contains a ListView\n that allows the user to select one of the wallets listed in the\n wallet directory.\n\n This PR uses the arrow icon that is shared with the Tooltip so it is based off of that commit.\n\n [![Build Artifacts](https://img.shields.io/badge/Build%20Artifacts-green\n )](https://github.com/bitcoin-core/gui-qml/actions/runs/9263281845)\n\nACKs for top commit:\n D33r-Gee:\n tACK [0939f2b](https://github.com/bitcoin-core/gui-qml/commit/0939f2bfd7586c04ad35aabffc5028511c1a236f) on WSL Ubuntu 22.04\n\nTree-SHA512: 19b877ca1be7488c54e79dba28720818711ab9f9f8de34cdb4f540daa150dc6debb8d78d9e0ba14b8a246f88497f6a04b089bcd3e4dca433afe49990201439d9","shortMessageHtmlLink":"Merge bitcoin-core#401: Introduce Wallet Select Dropdown"}},{"before":"c065a17375e6a141c90c74d051ce2911ddecd26b","after":"a73577b7b79d541472a80471a6adcadebe6d9deb","ref":"refs/heads/main","pushedAt":"2024-08-01T16:29:46.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#403: Introduce Create Single-Sig wallet flow\n\na3de25576f1ae86c60176885c0466e081059161b qml: Introduce Create Wallet Single-Sig flow (johnny9)\n02667428534ac09214067eef16faa07aba032b3e qml: Introduce AddWallet page after onboarding (johnny9)\n931d4420a6aac87813e3074a416f643c8bfdf96c qml: Add DISABLED state to ContinueButton (johnny9)\n4f11e01e24a05aea3c519a0580aa2a0b1be57a37 qml: Add color properties to ContinueButton (johnny9)\n\nPull request description:\n\n These changes add more pages after the initial onboarding.\n\n To test, run the application with the `-resetguisettings` option.\n\n Link to github actions build artifacts.\n\n [![Build Artifacts](https://img.shields.io/badge/Build%20Artifacts-green\n )](https://github.com/bitcoin-core/gui-qml/actions/runs/9263281845)\n\nACKs for top commit:\n D33r-Gee:\n tACK [a3de255](https://github.com/bitcoin-core/gui-qml/commit/a3de25576f1ae86c60176885c0466e081059161b) on WSL Ubuntu 22.04\n\nTree-SHA512: 9970996d1b26a9db7733b050e13d37494c7f0ebbcb0faa00b3a565a5aaeb634ac1d7ad38c11a0de34d15f28c52be953935d025b979e132990bc7dc70a84964a8","shortMessageHtmlLink":"Merge bitcoin-core#403: Introduce Create Single-Sig wallet flow"}},{"before":"364e41dcee0cb2d0be5fa654db027fd605d8021c","after":"c065a17375e6a141c90c74d051ce2911ddecd26b","ref":"refs/heads/main","pushedAt":"2024-06-09T11:32:44.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#407: ci: Fix broken jobs\n\nd04cfc9e72c6955b76e62ae28995207ef0dc6033 ci: Set `IN_GETOPT_BIN` environment variable for native macOS job (Hennadii Stepanov)\n568dbbe1f25ef6be5c32b9f96b05e5ca6b4106db ci: Disable fuzz tests for \"macOS 13 native\" job (Hennadii Stepanov)\n6a4f0273dccc2787705b1498e220603abdaf22b5 ci: Disable benchmarks for \"Win64 native\" job (Hennadii Stepanov)\n91a2b37407379917d4cec7f9a95e2f452910213f build: disable external-signer for Windows (fanquake)\n5cbb35b529482831ee0eeb21ab5f131620ea42c3 build, msvc: Update vcpkg baseline (Hennadii Stepanov)\nc0e608a68d70a880257490b7c248b5defce84538 ci: Delete no longer needed workaround in native Windows job (Hennadii Stepanov)\n\nPull request description:\n\n See commit messages for details.\n\nACKs for top commit:\n pablomartin4btc:\n ACK d04cfc9e72c6955b76e62ae28995207ef0dc6033\n\nTree-SHA512: eaab8bbdb5638df192dafd7b06fd01a04d2f3cbb795edf8d1f1961836d80df8f8d75cef82f07af2f79447db26b62d45dab1eeaa1acad9306c575b75be59cb0eb","shortMessageHtmlLink":"Merge bitcoin-core#407: ci: Fix broken jobs"}},{"before":"de4604ee7371aae8edc80f592937fe054c929053","after":"d04cfc9e72c6955b76e62ae28995207ef0dc6033","ref":"refs/heads/240608-ci-macos","pushedAt":"2024-06-08T19:13:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"ci: Set `IN_GETOPT_BIN` environment variable for native macOS job","shortMessageHtmlLink":"ci: Set IN_GETOPT_BIN environment variable for native macOS job"}},{"before":"635eb04fdd30e58180d719c293743ab3863088da","after":"de4604ee7371aae8edc80f592937fe054c929053","ref":"refs/heads/240608-ci-macos","pushedAt":"2024-06-08T14:41:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"ci: Set `IN_GETOPT_BIN` environment variable for native macOS job","shortMessageHtmlLink":"ci: Set IN_GETOPT_BIN environment variable for native macOS job"}},{"before":"175337ff8f77815c22ba580c22d8830525e1d5a8","after":"635eb04fdd30e58180d719c293743ab3863088da","ref":"refs/heads/240608-ci-macos","pushedAt":"2024-06-08T13:18:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"build: disable external-signer for Windows\n\nIt's come to light that Boost ASIO (a Boost Process sub dep) has in some\ninstances, been queitly initialising our network stack on Windows (see\nPR #28486 and discussion in #28940).\n\nThis has been shielding a bug in our own code, but the larger issue\nis that Boost Process/ASIO is running code before main, and doing things\nlike setting up networking. This undermines our own assumptions about\nhow our binary works, happens before we get to run any sanity checks,\nand also runs before we call our own code to setup networking.\n\nIt's also not clear why a feature like external signer would have a\ndependency that would be doing anything network/socket related, given it\nonly exists to spawn a local process.","shortMessageHtmlLink":"build: disable external-signer for Windows"}},{"before":"d33494f59ca2f20a782cc78523d80cf2ef287278","after":"175337ff8f77815c22ba580c22d8830525e1d5a8","ref":"refs/heads/240608-ci-macos","pushedAt":"2024-06-08T11:15:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"build, msvc: Update vcpkg baseline","shortMessageHtmlLink":"build, msvc: Update vcpkg baseline"}},{"before":"4ef0759d958748ff9c7db5ffa7c2080612897b26","after":"d33494f59ca2f20a782cc78523d80cf2ef287278","ref":"refs/heads/240608-ci-macos","pushedAt":"2024-06-08T11:08:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"build: disable external-signer for Windows\n\nIt's come to light that Boost ASIO (a Boost Process sub dep) has in some\ninstances, been queitly initialising our network stack on Windows (see\nPR #28486 and discussion in #28940).\n\nThis has been shielding a bug in our own code, but the larger issue\nis that Boost Process/ASIO is running code before main, and doing things\nlike setting up networking. This undermines our own assumptions about\nhow our binary works, happens before we get to run any sanity checks,\nand also runs before we call our own code to setup networking.\n\nIt's also not clear why a feature like external signer would have a\ndependency that would be doing anything network/socket related, given it\nonly exists to spawn a local process.","shortMessageHtmlLink":"build: disable external-signer for Windows"}},{"before":"46e655ba2c7423a783e4aa978f364969c5625baf","after":"4ef0759d958748ff9c7db5ffa7c2080612897b26","ref":"refs/heads/240608-ci-macos","pushedAt":"2024-06-08T10:42:38.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"ci: Delete no longer needed workaround in native Windows job\n\nSee https://github.com/actions/runner-images/issues/9701.","shortMessageHtmlLink":"ci: Delete no longer needed workaround in native Windows job"}},{"before":"6a1b9b78e0e49df2562f429d523d067ec3006571","after":"46e655ba2c7423a783e4aa978f364969c5625baf","ref":"refs/heads/240608-ci-macos","pushedAt":"2024-06-08T10:29:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"build, msvc: Update vcpkg baseline","shortMessageHtmlLink":"build, msvc: Update vcpkg baseline"}},{"before":null,"after":"6a1b9b78e0e49df2562f429d523d067ec3006571","ref":"refs/heads/240608-ci-macos","pushedAt":"2024-06-08T08:32:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"ci: Disable fuzz tests for \"macOS 13 native\" job\n\nFuzz tests cause timeout for reasons unrelated to the QML GUI\ndevelopment.\n\nCan be reverted back after syncing the QML repository with the main one.","shortMessageHtmlLink":"ci: Disable fuzz tests for \"macOS 13 native\" job"}},{"before":"a7ccfc3fbd7c99ab0ac524f1203a74a0c97e7a9d","after":"364e41dcee0cb2d0be5fa654db027fd605d8021c","ref":"refs/heads/main","pushedAt":"2024-06-08T08:05:47.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#397: UI Only Custom Datadir Display\n\n7a8fb19db1db138e50d7762aef2658737a3d6f8c qml: UI only display datadir functionality (D33r-Gee)\nb648cbb2deffe5c97f371b5d2e31931fdc0dc81e qml: added getting custom datadir for display (D33r-Gee)\n\nPull request description:\n\n This pull request builds upon #392 and introduces enhancements to display the data directory information within the UI. This functionality encompasses both default and custom data directory paths, fulfilling the UI requirements for user-defined data directory selection initiated in #273.\n\n Also the custom datadir is not persistent at the moment it will be once the back end wiring is added.\n\n
\n Ubuntu 22.04 Screenshots\n\n ![datadir_desktop](https://github.com/bitcoin-core/gui-qml/assets/111142327/639873a5-fd5d-44ac-b0be-66e0762a08db)\n\n
\n\n
\n Android Screenshots\n\n ![datadir_mobile_720](https://github.com/bitcoin-core/gui-qml/assets/111142327/e6fcd12b-f6e6-4efc-adba-071d2caaddef)\n\n
\n\n As a potential follow-up enhancement, consider incorporating mechanisms for saving the data directory path. This could be achieved through:\n\n - Double-click functionality: Allow users to save the displayed path by simply double-clicking on it. This provides a convenient and intuitive method for desktop environments.\n\n - Dedicated button: For mobile use cases or scenarios where double-clicking might not be feasible, introduce a dedicated \"Save Path\" button. This ensures a clear and accessible action for users on various devices.\n\nACKs for top commit:\n GBKS:\n ACK 7a8fb19. Looks and feels great, just tested again on MacOS.\n MarnixCroes:\n tACK 7a8fb19db1db138e50d7762aef2658737a3d6f8c on Ubuntu desktop\n pablomartin4btc:\n reACK 7a8fb19\n\nTree-SHA512: 4be20832b72fee99046e78ce45e766ff3f00fc556d57c47311828daa3270d1980fdb2b16b95715024a5835f5730f4a3a347337e9dcc22f57fbaf2ac6711a9f6d","shortMessageHtmlLink":"Merge bitcoin-core#397: UI Only Custom Datadir Display"}},{"before":"cf820e5e623b67c1b6ae9a88698845ef0480949a","after":"a7ccfc3fbd7c99ab0ac524f1203a74a0c97e7a9d","ref":"refs/heads/main","pushedAt":"2024-05-27T11:52:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#400: Introduce Tooltip for the BlockClock navbar button\n\n8f8341f6598afaa44e0370a67c7379fab78dd34c qml: Introduce Tooltip for the BlockClock navbar button (johnny9)\n\nPull request description:\n\n The Tooltip will appear when hovering over the BlockClock tab button in the desktop navigation bar. It will show the current state of IBD.\n\n Two things are different than the figma. The wording for remaining blocks matches what is shown on the BlockClock instead of what the figma shows and After sync, Blockheight is shown instead. Looking for opinions on both during review.\n\n ![vlcsnap-2024-05-01-20h05m06s361](https://github.com/bitcoin-core/gui-qml/assets/985648/fb4b6da1-ac76-4e82-b515-977f09caee51)\n\n [![Build Artifacts](https://img.shields.io/badge/Build%20Artifacts-green\n )](https://github.com/bitcoin-core/gui-qml/actions/runs/9012143092?pr=400)\n\nACKs for top commit:\n D33r-Gee:\n tACK 8f8341f6598afaa44e0370a67c7379fab78dd34c on WSL Ubuntu 22.04 LGTM\n pablomartin4btc:\n re-tACK 8f8341f6598afaa44e0370a67c7379fab78dd34c\n\nTree-SHA512: c61980b31eed9d4a632dbccc59e4b7ef3effb019e70eea06597f908ba59f83322e49d9cd1c57ec51267e9af32976d63c8ce9deea8b2b89b5c3858ea5f81f0223","shortMessageHtmlLink":"Merge bitcoin-core#400: Introduce Tooltip for the BlockClock navbar b…"}},{"before":"14206cd0d9a89741b7ca484b311820863d8be8f3","after":null,"ref":"refs/heads/240526-ci-update.DEBUG.0","pushedAt":"2024-05-27T09:05:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"}},{"before":"a4855332d4956ebc795734ae790eb7d3fe971b7a","after":null,"ref":"refs/heads/240526-ci-update","pushedAt":"2024-05-27T09:05:30.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"}},{"before":"84d388d61746a5b834080ea727a3f99820292a86","after":"cf820e5e623b67c1b6ae9a88698845ef0480949a","ref":"refs/heads/main","pushedAt":"2024-05-27T09:05:23.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#402: ci, build: Update GHA actions and fix build bugs\n\na4855332d4956ebc795734ae790eb7d3fe971b7a build: Re-add `qt/guiconstants.h` header (Hennadii Stepanov)\n87909c1c4f3893566106a426fc1e4ceb4f0a58d2 build: Add missed `IPAddressValueInput.qml` to `QML_RES_QML` (Hennadii Stepanov)\n935ee298737b6ec1970cb25544c41164f103a050 build: Fix `-Xclang -internal-isystem` option (Hennadii Stepanov)\nac32ee9917f06b69e03afb2d93becd5e07c52e57 ci: Update GHA actions (Hennadii Stepanov)\n\nPull request description:\n\n The second commit has been cherry-picked from https://github.com/bitcoin/bitcoin/pull/29195.\n\n Link to github actions build artifacts:\n\n [![Build Artifacts](https://img.shields.io/badge/Build%20Artifacts-green\n )](https://github.com/bitcoin-core/gui-qml/actions/runs/9242930899)\n\nACKs for top commit:\n pablomartin4btc:\n ACK a4855332d4956ebc795734ae790eb7d3fe971b7a\n johnny9:\n ACK a4855332d4956ebc795734ae790eb7d3fe971b7a\n\nTree-SHA512: ca5222033d4fd1bae3a128f8037187cd5d1d0c3a262a3034dda3d88b22463342016a0162e5ca9415a9db76a6dde8c205a183edf7cbb0e1dd722b4742d05ce9b2","shortMessageHtmlLink":"Merge bitcoin-core#402: ci, build: Update GHA actions and fix build bugs"}},{"before":"a4855332d4956ebc795734ae790eb7d3fe971b7a","after":null,"ref":"refs/tags/pr154.01","pushedAt":"2024-05-26T11:38:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"}},{"before":"87909c1c4f3893566106a426fc1e4ceb4f0a58d2","after":"a4855332d4956ebc795734ae790eb7d3fe971b7a","ref":"refs/heads/240526-ci-update","pushedAt":"2024-05-26T11:36:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"build: Re-add `qt/guiconstants.h` header\n\nThis was overlooked in https://github.com/bitcoin-core/gui-qml/pull/398.","shortMessageHtmlLink":"build: Re-add qt/guiconstants.h header"}},{"before":"935ee298737b6ec1970cb25544c41164f103a050","after":"87909c1c4f3893566106a426fc1e4ceb4f0a58d2","ref":"refs/heads/240526-ci-update","pushedAt":"2024-05-26T10:10:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"build: Add missed `IPAddressValueInput.qml` to `QML_RES_QML`\n\nThis was overlooked in https://github.com/bitcoin-core/gui-qml/pull/391.","shortMessageHtmlLink":"build: Add missed IPAddressValueInput.qml to QML_RES_QML"}},{"before":"ac32ee9917f06b69e03afb2d93becd5e07c52e57","after":"935ee298737b6ec1970cb25544c41164f103a050","ref":"refs/heads/240526-ci-update","pushedAt":"2024-05-26T09:56:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"build: Fix `-Xclang -internal-isystem` option\n\nLLVM Clang >=16.0 and Apple Clang >=15.0 do not recognize\n`-Xclang -internal-isystem/usr/local/include` anymore.\n\nFor example, see: https://github.com/llvm/llvm-project/commit/cbbe1d44546db52c71c9a2b18f85b87ae82df9e7","shortMessageHtmlLink":"build: Fix -Xclang -internal-isystem option"}},{"before":null,"after":"14206cd0d9a89741b7ca484b311820863d8be8f3","ref":"refs/heads/240526-ci-update.DEBUG.0","pushedAt":"2024-05-26T09:48:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"debug --","shortMessageHtmlLink":"debug --"}},{"before":null,"after":"ac32ee9917f06b69e03afb2d93becd5e07c52e57","ref":"refs/heads/240526-ci-update","pushedAt":"2024-05-26T09:39:20.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"ci: Update GHA actions","shortMessageHtmlLink":"ci: Update GHA actions"}},{"before":"085805ff8651711aa251f26ba783a267b4895403","after":"84d388d61746a5b834080ea727a3f99820292a86","ref":"refs/heads/main","pushedAt":"2024-05-14T19:05:33.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#284: Only write options after onboarding\n\n9e569074a1735976ffb324dfb5531c24591f3252 qml: only write options after onboarding (johnny9)\nc0ebff2971221cad1cf4819544505a3b22ed8055 qml: Set OptionQmlModel initial property values (johnny9)\n\nPull request description:\n\n [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/284)\n [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/284)\n [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/284)\n [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/284)\n\nACKs for top commit:\n D33r-Gee:\n re ACK 9e569074a1735976ffb324dfb5531c24591f3252 on Ubuntu 22.04 works as expected\n pablomartin4btc:\n re-ACK 9e569074a1735976ffb324dfb5531c24591f3252\n\nTree-SHA512: 6835569e9a3ab340c94c507867c578e46bb86d8c0c8cad639ed97dd09e7edcdbe2b21c1b58fab74c989cbda22acc768dc6004e27d9a6a66b085ea5ac3ec49474","shortMessageHtmlLink":"Merge bitcoin-core#284: Only write options after onboarding"}},{"before":"b80e16750fd591f62a17970e8c5f4c279ae102b6","after":"085805ff8651711aa251f26ba783a267b4895403","ref":"refs/heads/main","pushedAt":"2024-04-24T18:53:27.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#398: Using a different configuration file name from QT\n\n5be1e52fa66eaa4a52d9a1457f50fa22037c91f0 qml, refactoring: Separate guiconstants from QT (pablomartin4btc)\n\nPull request description:\n\n At the moment both QT and QML gui apps are using the same naming convention for configuration files (`Bitcoin*.conf`), so separating `guiconstants.h` file from QT, copying it from `src/qt` to `src/qml` and updating `QAPP_APP_NAME_*` constants values will avoid them clashing with each other trying to persist/ read same or different settings (e.g. configuration file for QT on signet will be still named as `Bitcoin-Qt-signet.conf`, as of today, while QML will start using a separate file named `Bitcoin-Qml-signet.conf` - before this fix, currently sometimes a user can get a warning on reading incorrect settings or values: `QVariant::load: unknown user type with name BitcoinUnits::Unit.`).\n\n This could be a temporary fix (? - gui constants file contents has been cleaned up as [suggested](https://github.com/bitcoin-core/gui-qml/pull/398#issuecomment-2054563863)) so instances from both QT and QML gui apps don't interfere between them during QML development. This change will be transparent for both QT gui app and users.\n\n
\n Sample of a separate QT config file on signet (Bitcoin-Qt-signet.conf).\n\n ```\n [General]\n DisplayBitcoinUnit=@Variant(\\0\\0\\0\\x7f\\0\\0\\0\\x13\\x42itcoinUnits::Unit\\0\\0)\n MainWindowGeometry=@ByteArray(\\x1\\xd9\\xd0\\xcb\\0\\x3\\0\\0\\0\\0\\x2\\xa3\\0\\0\\x1v\\0\\0\\x5\\xb0\\0\\0\\x3^\\0\\0\\x2\\xa3\\0\\0\\x1v\\0\\0\\x5\\xb0\\0\\0\\x3^\\0\\0\\0\\0\\0\\0\\0\\0\\a\\x80\\0\\0\\x2\\xa3\\0\\0\\x1v\\0\\0\\x5\\xb0\\0\\0\\x3^)\n PeersTabBanlistHeaderState=@ByteArray()\n PeersTabPeerHeaderState=@ByteArray()\n RPCConsoleWindowGeometry=@ByteArray(\\x1\\xd9\\xd0\\xcb\\0\\x3\\0\\0\\0\\0\\x2q\\0\\0\\x1\\x8f\\0\\0\\x5T\\0\\0\\x3<\\0\\0\\x2q\\0\\0\\x1\\x8f\\0\\0\\x5T\\0\\0\\x3<\\0\\0\\0\\0\\0\\0\\0\\0\\a\\x80\\0\\0\\x2q\\0\\0\\x1\\x8f\\0\\0\\x5T\\0\\0\\x3<)\n RPCConsoleWindowPeersTabSplitterSizes=@ByteArray(\\0\\0\\0\\xff\\0\\0\\0\\x1\\0\\0\\0\\x2\\xff\\xff\\xff\\xff\\xff\\xff\\xff\\xff\\0\\xff\\xff\\xff\\xff\\x1\\0\\0\\0\\x1\\0)\n SubFeeFromAmount=false\n enable_psbt_controls=false\n fCoinControlFeatures=false\n fHideTrayIcon=false\n fMinimizeOnClose=false\n fMinimizeToTray=false\n fRestartRequired=false\n nSettingsVersion=279900\n strDataDir=/home/pablo/.bitcoin\n strThirdPartyTxUrls=\n ```\n\n
\n
\n Sample of a separate QML config file on signet (Bitcoin-Qml-signet.conf).\n\n ```\n [General]\n blockclocksize=0.4166666666666667\n dark=true\n height=665\n width=640\n x=755\n y=339\n ```\n\n
\n\nTop commit has no ACKs.\n\nTree-SHA512: ce738a21488ac8fae9187fe6eec57e53ae77c18c91190c0ab199d63071fec830152a5f9d54132cc99d94b8c6f42224a6f8c0062bac06af82e5ca670a490e6596","shortMessageHtmlLink":"Merge bitcoin-core#398: Using a different configuration file name fro…"}},{"before":"c3fb55763037515dfd66101dd56b655eef5e7d05","after":"b80e16750fd591f62a17970e8c5f4c279ae102b6","ref":"refs/heads/main","pushedAt":"2024-04-10T06:12:15.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui-qml#395: Correct Default Proxy header description on ProxySettings - Follow-up #391\n\nd558b05dda37bc135936969d4d53210b51e0e7fc qml, component: Fix labelling on ProxySettings (pablomartin4btc)\n\nPull request description:\n\n This is a follow-up from https://github.com/bitcoin-core/gui-qml/pull/391#issuecomment-2030046949.\n\n
\n Currently/ main branch screenshot.\n\n ![Screenshot from 2024-04-07 23-00-31](https://github.com/bitcoin-core/gui-qml/assets/110166421/ffb86641-9f98-46d0-98d4-3c7ffd826d4e)\n\n
\n
\n This PR branch screenshot.\n\n ![image](https://github.com/bitcoin-core/gui-qml/assets/110166421/279abc03-8417-4345-bb21-06a7ff53eae6)\n\n
\n\nACKs for top commit:\n GBKS:\n tACK d558b05\n D33r-Gee:\n tACK d558b05dda37bc135936969d4d53210b51e0e7fc\n\nTree-SHA512: b849bf2addafeac85e645281be162cf22d2f34da613f3da3fcef42377546a33e1b19beacb66660e06bc2e55b6b3c10bae08cf0ecdafb1e470fb8d44b040b6ff0","shortMessageHtmlLink":"Merge bitcoin-core#395: Correct Default Proxy header description on P…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMVQwOTowMDozMC4wMDAwMDBazwAAAASy-ANp","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMVQwOTowMDozMC4wMDAwMDBazwAAAASy-ANp","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNC0xMFQwNjoxMjoxNS4wMDAwMDBazwAAAAQstDiv"}},"title":"Activity · hebasto/gui-qml"}