-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete faulty almaMmsId mappings that are refering to local records #107
Comments
Also there are a lot of duplicate almaMmsId in the file:
This seems to be related to https://jira.hbz-nrw.de/projects/RPB/issues/RPB-232 |
Does it make sense to recreate this mapping file after fixing jira.hbz-nrw.de/projects/RPB/issues/RPB-232 |
Sounds reasonable. +1 |
As I commented in #108, I don't understand. As we discussed on the RPB channel recently, isn't this only the original file created here, which has then been moved to lookup-tables? https://github.com/hbz/rpb/commits/main/conf/maps/almaMmsId-to-rpbId.tsv |
I am not sure if they are the result of the same process. They have a diffrent size: lookup tables +14.000 and this one here has ~45.000. The one with 45.000 is based on the existing hbzId in RPB: https://rpb.lbz-rlp.de/search?location=&q=_exists_%3AhbzId This difference in size hints that they seem to be different files. |
Wir können/sollten im rpb-Repo auch einfach Deutsch schreiben... Bleibt die Frage: Wird diese Datei momentan überhaupt für irgendetwas verwendet? Wenn nicht, können und sollten wir das auf später schieben. Wie im gestrigen Treffen gesagt, müssen wir eines nach dem anderen machen. Der momentane Fokus ist auf RPB-184 und damit hat das hier nichts zu tun und verschafft uns nur zusätzliche Mental Load. |
conf/maps/almaMmsId-to-rpbId.tsv has some mappings that are oviously wrong.
They are not mapped to a NZ record these would have at least 6441 at the end of the almaMmsId.
But they are also mapping to completly wrong or non existing records.
Not sure how they were mapped:
6452
991000117199706452 107t01165452
991000087399706452 107t01165454
6449
991010785389706449 107t01165591
6456
991005467559706456 929t01077759
The text was updated successfully, but these errors were encountered: