Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't put with ttl on transactional map #1254

Open
JorgenPo opened this issue Jan 20, 2025 · 2 comments
Open

Can't put with ttl on transactional map #1254

JorgenPo opened this issue Jan 20, 2025 · 2 comments

Comments

@JorgenPo
Copy link

When using transactional map, there is no put with ttl method overload:

boost::future< boost::optional< R > > put (const K &key, const V &value, std::chrono::milliseconds ttl);

But there is such method in imap interface class. In java client both maps (ordinary and transactional) use a common interface for map and put methods are equal.

Expected behavior
Method boost::future< boost::optional< R > > put (const K &key, const V &value, std::chrono::milliseconds ttl); is available in hazelcast::client::transactional_map.

Actual behavior
Method boost::future< boost::optional< R > > put (const K &key, const V &value, std::chrono::milliseconds ttl); is not available in hazelcast::client::transactional_map.

@ihsandemir
Copy link
Collaborator

Hello @JorgenPo I agree, this API can be added. It was probably added later for the Java API and it can be added to C++ client as well.

Would you like to submit a PR for it?

JorgenPo added a commit to JorgenPo/hazelcast-cpp-client that referenced this issue Jan 23, 2025
@JorgenPo
Copy link
Author

Hello @JorgenPo I agree, this API can be added. It was probably added later for the Java API and it can be added to C++ client as well.

Would you like to submit a PR for it?

I prepared a PR that should fix the issue, could you please have a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants