From 671a09d1df56439377c9fe68100559d2b5587f18 Mon Sep 17 00:00:00 2001 From: Eliza Weisman Date: Tue, 31 Dec 2024 10:40:11 -0800 Subject: [PATCH] fix(hal-x86_64): don't log every MSR read This was a stupid thing to do, and I only did it because I was being excessively cutesy. Now that we read the FS_GS_BASE MSR in ISRs to access local data, this can deadlock the kernel :upside_down: --- hal-x86_64/src/cpu/msr.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hal-x86_64/src/cpu/msr.rs b/hal-x86_64/src/cpu/msr.rs index 69547ed5..abfb8126 100644 --- a/hal-x86_64/src/cpu/msr.rs +++ b/hal-x86_64/src/cpu/msr.rs @@ -281,9 +281,7 @@ impl Msr { options(nomem, nostack, preserves_flags) ); } - let result = (hi as u64) << 32 | (lo as u64); - tracing::trace!(rdmsr = %self, value = fmt::hex(result)); - result + (hi as u64) << 32 | (lo as u64) } /// Writes the given raw `u64` value to this MSR.