Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#31] Refactoring candlesticks update #120

Merged
merged 1 commit into from
Feb 26, 2022
Merged

[#31] Refactoring candlesticks update #120

merged 1 commit into from
Feb 26, 2022

Conversation

fbn-roussel
Copy link
Collaborator

@fbn-roussel fbn-roussel commented Feb 23, 2022 •
edited
Loading

This first PR doesn't handle when exchange API is down but improve update process.

@fbn-roussel fbn-roussel added the enhancement New feature or request label Feb 23, 2022
@fbn-roussel fbn-roussel self-assigned this Feb 23, 2022
@fbn-roussel fbn-roussel marked this pull request as draft February 23, 2022 20:56
@fbn-roussel fbn-roussel marked this pull request as ready for review February 26, 2022 16:22
@fbn-roussel fbn-roussel force-pushed the feat/31-candlesticks-gaps-handling branch from e41b18d to 05ffe86 Compare February 26, 2022 16:23
@fbn-roussel fbn-roussel linked an issue Feb 26, 2022 that may be closed by this pull request
Handle exchange API down while updating candlesticks #31
Open
@fbn-roussel fbn-roussel changed the title [#31] Handle exchange API down while updating candlesticks [#31] Refactoring candlesticks update Feb 26, 2022
@fbn-roussel fbn-roussel force-pushed the feat/31-candlesticks-gaps-handling branch from 05ffe86 to 113bdd2 Compare February 26, 2022 16:28
@fbn-roussel fbn-roussel added this to In progress in BOT trading via automation Feb 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@fbn-roussel fbn-roussel merged commit 701b88c into main Feb 26, 2022
BOT trading automation moved this from In progress to Done Feb 26, 2022
@fbn-roussel fbn-roussel deleted the feat/31-candlesticks-gaps-handling branch February 26, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fbn-roussel fbn-roussel

Labels
enhancement New feature or request
Projects
BOT trading
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle exchange API down while updating candlesticks
1 participant
@fbn-roussel