CODE RUB: ShouldThrowValidationExceptionOnModifyIfStorageStudentAuditInformationNotSameAsInputStudentAuditInformationAndLogItAsync

[mtoncic]

ShouldThrowValidationExceptionOnModifyIfStorageStudentAuditInformationNotSameAsInputStudentAuditInformationAndLogItAsync in StudentServiceTests.Validations.Modify.cs not using SameValidationExceptionAs, therefore not checking the inner exception details.

[hassanhabib]

@mtoncic this sounds very very smart and promising. Create a PR for one test and let me take a look. If this works that's what I call a Standard-Change - you get 100 points for that because it will help infinite number of engineers write better code. thank you for the thoughtful suggestion.

[mtoncic]

@hassanhabib hahah if you just could see my reaction when I read 100 points and then realizing that I copy-pasted wrong piece of code to be replaced :)
Will create separate issue for the code simplification since it's for another test.

Maybe some other time :)

[ShriHumrudha]

I see two things:

1. Student should not implemented IAduitable
2. SameExceptionAs method should be changed to SameValidationExceptionAs

What is the proposing standard change here?

[mtoncic]

@ShriHumrudha that was the other part that I moved into other issue. There is no Standard change just small simplification :)