Skip to content

Hover does not work for type symbols from external packages #717

Closed
@jacg

Description

@jacg

... as documented by the tests titled type constructor from other package, value from other package and external class is signature.

To be precise, hover does work for external values, but not types.

Activity

added 2 commits that reference this issue on Dec 17, 2019
jneira

jneira commented on Sep 16, 2020

@jneira
Member

I've just test this and goto def to external packages does not work but hover on external values/types does

transferred this issue fromhaskell/ghcideon Dec 29, 2020
jneira

jneira commented on Dec 29, 2020

@jneira
Member

Test in hls are in:

, test broken yes xtcL5 xtc "type constructor external #248,249"
, test broken yes xvL20 xvMsg "value external package #249" -- 120

, test broken broken outL45 outSig "top-level signature #310"
, test broken broken innL48 innSig "inner signature #310"

changed the title [-]Hover / goto def do not work for symbols from external packages[/-] [+]Hover does not work for symbols from external packages[/+] on Dec 29, 2020
added
type: bugSomething isn't right: doesn't work as intended, documentation is missing/outdated, etc..
on Dec 29, 2020
Anton-Latukha

Anton-Latukha commented on Dec 21, 2021

@Anton-Latukha
Collaborator

I believe it works now.

jneira

jneira commented on Dec 21, 2021

@jneira
Member

Afaik the broken mark in tests should make the test fail if they are fixed. Although maybe they fail for another reason.
In other similar issue i removed the broken mark to check if the test continue failing for the same reason.

jacg

jacg commented on Dec 21, 2021

@jacg
ContributorAuthor

I regret that I don't have the time to work on this any more. 😞

Afaik the broken mark in tests should make the test fail if they are fixed.

Yes, that was the original intention when I wrote these tests. IIRC, it did actually work like that, at least at the beginning.

jneira

jneira commented on Dec 21, 2021

@jneira
Member

Although maybe they fail for another reason.

It happened to me for the top level signature/inner signature (they are handled in another issue)
I removed the broken mark and both continue failing obviusly. But visually top-level signature was fixed!
The test was failing due to the hover position, slightly different. Fixing hover position in the test made it green.

changed the title [-]Hover does not work for symbols from external packages[/-] [+]Hover does not work for type symbols from external packages[/+] on Jan 22, 2022
hasufell

hasufell commented on Jul 13, 2022

@hasufell
Member

I'm not sure if this ticket is still relevant. There are other tickets for goto definition like #708

Feel free to re-open this ticket with a clarification.

soulomoon

soulomoon commented on May 17, 2024

@soulomoon
Collaborator

We should enable the test for it too. doing at #4241

added a commit that references this issue on May 17, 2024
linked a pull request that will close this issueEnable test for #717 #4241on May 17, 2024
added a commit that references this issue on May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    component: ghcidetype: bugSomething isn't right: doesn't work as intended, documentation is missing/outdated, etc..

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @jneira@hasufell@jacg@soulomoon@Anton-Latukha

      Issue actions

        Hover does not work for type symbols from external packages · Issue #717 · haskell/haskell-language-server