You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
changed the title [-]Hover / goto def do not work for symbols from external packages[/-][+]Hover does not work for symbols from external packages[/+]on Dec 29, 2020
Afaik the broken mark in tests should make the test fail if they are fixed. Although maybe they fail for another reason.
In other similar issue i removed the broken mark to check if the test continue failing for the same reason.
It happened to me for the top level signature/inner signature (they are handled in another issue)
I removed the broken mark and both continue failing obviusly. But visually top-level signature was fixed!
The test was failing due to the hover position, slightly different. Fixing hover position in the test made it green.
changed the title [-]Hover does not work for symbols from external packages[/-][+]Hover does not work for type symbols from external packages[/+]on Jan 22, 2022
Activity
Fix #249 and #250
Fix #249 and #250
jneira commentedon Sep 16, 2020
The tests mentioned are:
https://github.com/haskell/ghcide/blob/8d478394afe072b02cb40a2a98baadbf1a787eda/test/exe/Main.hs#L2211-L2212
https://github.com/haskell/ghcide/blob/8d478394afe072b02cb40a2a98baadbf1a787eda/test/exe/Main.hs#L2220
jneira commentedon Sep 16, 2020
I've just test this and goto def to external packages does not work but hover on external values/types does
jneira commentedon Dec 29, 2020
Test in hls are in:
haskell-language-server/ghcide/test/exe/Main.hs
Lines 2487 to 2488 in d4f5d43
haskell-language-server/ghcide/test/exe/Main.hs
Lines 2517 to 2518 in d4f5d43
[-]Hover / goto def do not work for symbols from external packages[/-][+]Hover does not work for symbols from external packages[/+]Anton-Latukha commentedon Dec 21, 2021
I believe it works now.
jneira commentedon Dec 21, 2021
Afaik the broken mark in tests should make the test fail if they are fixed. Although maybe they fail for another reason.
In other similar issue i removed the broken mark to check if the test continue failing for the same reason.
jacg commentedon Dec 21, 2021
I regret that I don't have the time to work on this any more. 😞
Yes, that was the original intention when I wrote these tests. IIRC, it did actually work like that, at least at the beginning.
jneira commentedon Dec 21, 2021
It happened to me for the
top level signature
/inner signature
(they are handled in another issue)I removed the broken mark and both continue failing obviusly. But visually
top-level signature
was fixed!The test was failing due to the hover position, slightly different. Fixing hover position in the test made it green.
[-]Hover does not work for symbols from external packages[/-][+]Hover does not work for type symbols from external packages[/+]hasufell commentedon Jul 13, 2022
I'm not sure if this ticket is still relevant. There are other tickets for goto definition like #708
Feel free to re-open this ticket with a clarification.
soulomoon commentedon May 17, 2024
We should enable the test for it too. doing at #4241
enable test for #717
Enable test for #717 (#4241)