Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unconditional time out wait for diagnostic. See expectNoMoreDiagnostics #4300

Open
1 of 4 tasks
Tracked by #4299
soulomoon opened this issue Jun 9, 2024 · 0 comments
Open
1 of 4 tasks
Tracked by #4299

Comments

@soulomoon
Copy link
Collaborator

soulomoon commented Jun 9, 2024

It it not an easy job to remove this one. There are multiple states we need to monitor to wait for hls to settle.
After discussion with @michaelpj , we can replace the expectNoMoreDiagnostics's time out with following:

  • restartQueue empty
  • actionQueue empty
  • sessionLoader Queue empty
  • rebouncer done
  • hls-graph database all running is done

What we need to do:

@soulomoon soulomoon changed the title Unconditional time out wait for diagnostic. See expectNoMoreDiagnostics Remove Unconditional time out wait for diagnostic. See expectNoMoreDiagnostics Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant