Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out how absolutizing paths should work #4278

Open
michaelpj opened this issue Jun 4, 2024 · 0 comments
Open

Work out how absolutizing paths should work #4278

michaelpj opened this issue Jun 4, 2024 · 0 comments
Labels
type: enhancement New feature or request

Comments

@michaelpj
Copy link
Collaborator

Is your enhancement request related to a problem? Please describe.

We realised in #4231 that we don't really know how we are supposed to absolutise paths. We have a few cases:

  1. File paths that come from other tools, e.g. cabal. Probably these need to be relative to our working directory; or ideally we should avoid doing things that depend on our working directory at all.
  2. File paths that come from the client. Probably these need to be relative to a LSP workspace folder, but it's not entirely clear.
    • This is tricky: how do we know which workspace folder to use? Maybe we have to guess from the request? At least it would be nice to have whatever weird heuristic we end up with written down in some code.

It would be nice to tidy this up, but it probably relies on #4277 so we can actually tell where this is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants