You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your enhancement request related to a problem? Please describe.
Making paths absolute can be a bit tricky for us, since it's somewhat unclear where HLS is supposed to be running, and hence what relative paths are supposed to be relative to.
But at the moment we don't even really know the scope of the problem. Hopefully, most of the time we are dealing with absolute paths, but we have various random places where we make things absolute. It would make things a lot clearer if this was tracked in the types.
Describe the solution you'd like
Use one of the typed path libraries for file paths. We might also need to adjust our NormalizedFilePath and NormalizedUri types to track whether they are relative or absolute, but ideally we would use the same mechanics there as whatever typed path library we use.
Describe alternatives you've considered
Roll our own typed path library. This might be worth it if it's not much code.
The text was updated successfully, but these errors were encountered:
path supports distinguishing between absolute/relative paths in the types themselves. I think I'll be starting by replacing FilePath with Path wherever possible.
Edit: hand rolling a typed path library seems better due to a much narrower use-case.
Is your enhancement request related to a problem? Please describe.
Making paths absolute can be a bit tricky for us, since it's somewhat unclear where HLS is supposed to be running, and hence what relative paths are supposed to be relative to.
But at the moment we don't even really know the scope of the problem. Hopefully, most of the time we are dealing with absolute paths, but we have various random places where we make things absolute. It would make things a lot clearer if this was tracked in the types.
Describe the solution you'd like
Use one of the typed path libraries for file paths. We might also need to adjust our
NormalizedFilePath
andNormalizedUri
types to track whether they are relative or absolute, but ideally we would use the same mechanics there as whatever typed path library we use.Describe alternatives you've considered
Roll our own typed path library. This might be worth it if it's not much code.
The text was updated successfully, but these errors were encountered: