Remove unnecessary hie.yaml file creation in setup function

Author: soulomoon

ghcide-bench/src/Experiments.hs

@@ -671,50 +671,30 @@ callCommandLogging cmd = do
     output cmd
     callCommand cmd
 
-simpleCabalCradleContent :: String
-simpleCabalCradleContent = "cradle:\n  cabal:\n"
-
-simpleStackCradleContent :: String
-simpleStackCradleContent = "cradle:\n  stack:\n"
-
 -- | Setup the benchmark
--- we need to create a hie.yaml file for the examples
--- or the hie.yaml file would be searched in the parent directories recursively
--- implicit-hie is error prone for the example test `lsp-types-2.1.1.0`
--- we are using the simpleCabalCradleContent for the hie.yaml file instead.
--- it works if we have cabal > 3.2.
+-- we now rely on implicit hie.yaml discovery so no longer need to write one
 setup :: HasConfig => IO SetupResult
 setup = do
   benchDir <- case exampleDetails(example ?config) of
-      ExamplePath examplePath -> do
-          let hieYamlPath = examplePath </> "hie.yaml"
-          alreadyExists <- doesFileExist hieYamlPath
-          unless alreadyExists $ writeFile hieYamlPath simpleCabalCradleContent
-          return examplePath
+      ExamplePath examplePath -> return examplePath
       ExampleScript examplePath' scriptArgs -> do
           let exampleDir = examplesPath </> exampleName (example ?config)
           alreadySetup <- doesDirectoryExist exampleDir
           unless alreadySetup $ do
             createDirectoryIfMissing True exampleDir
             examplePath <- makeAbsolute examplePath'
             cmd_ (Cwd exampleDir) examplePath scriptArgs
-            let hieYamlPath = exampleDir </> "hie.yaml"
-            alreadyExists <- doesFileExist hieYamlPath
-            unless alreadyExists $ writeFile hieYamlPath simpleCabalCradleContent
 
           return exampleDir
       ExampleHackage ExamplePackage{..} -> do
         let path = examplesPath </> package
             package = packageName <> "-" <> showVersion packageVersion
-            hieYamlPath = path </> "hie.yaml"
         alreadySetup <- doesDirectoryExist path
         unless alreadySetup $
           case buildTool ?config of
             Cabal -> do
                 let cabalVerbosity = "-v" ++ show (fromEnum (verbose ?config))
                 callCommandLogging $ "cabal get " <> cabalVerbosity <> " " <> package <> " -d " <> examplesPath
-                let hieYamlPath = path </> "hie.yaml"
-                writeFile hieYamlPath simpleCabalCradleContent
                 -- Need this in case there is a parent cabal.project somewhere
                 writeFile
                     (path </> "cabal.project")
@@ -742,7 +722,6 @@ setup = do
                                 ,"compiler"]
                             ]
                         )
-                writeFile hieYamlPath simpleStackCradleContent
         return path
 
   whenJust (shakeProfiling ?config) $ createDirectoryIfMissing True