Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages on "known unsupported system"? #1079

Open
hasufell opened this issue Jun 9, 2024 · 0 comments
Open

Better error messages on "known unsupported system"? #1079

hasufell opened this issue Jun 9, 2024 · 0 comments

Comments

@hasufell
Copy link
Member

hasufell commented Jun 9, 2024

e.g. #1078

There are two ways to do such warnings:

  • the ghcup bootstrap script
  • ghcup binary when doing bindist selection

For the latter we could emit a warning IFF:

  • the platform/distro selected is not "unknown linux" (otherwise the warning will show on all non-major distros)
  • we have proper version information (e.g. FreeBSD 13.0)
  • there is no explicit match for this version, except the fallback "unknown_version"

This would require to carry additional information about our bindist matching (is it a proper hit or the catch-all case).

However, this would also require to review the metadata file, because it is well possible we use "unknown_version" rather eagerly, e.g. because the bindists built on that platform are very portable anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant