Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cabal (the library) advises use of extensions: when that field is deprecated #10042

Closed
mpilgrem opened this issue May 22, 2024 · 2 comments · Fixed by #10044
Closed

Cabal (the library) advises use of extensions: when that field is deprecated #10042

mpilgrem opened this issue May 22, 2024 · 2 comments · Fixed by #10044
Assignees
@mpilgrem
Labels
attention: pr-welcome re: user experience User experience (UX) issue type: enhancement

Comments

@mpilgrem
Copy link
Collaborator

mpilgrem commented May 22, 2024 •
edited
Loading

Motivation: commercialhaskell/stack#6589

If a Cabal file uses ghc-options: to set language extensions, Cabal (the library) will advise the use of extensions: even when extensions: has been deprecated in favour of default-extensions:.

EDIT: This appears to be true even if the cabal-version: specifies a Cabal package format version that no longer supports extensions: at all.
@ulysses4ever
Copy link
Collaborator

That's an oversight. PR fixing it is welcome!

@mpilgrem mpilgrem self-assigned this May 22, 2024
@mpilgrem
Copy link
Collaborator Author

I'll try to give the fix some attention in the coming days.

mpilgrem added a commit that referenced this issue May 22, 2024
@mpilgrem
Fix #10042 Don't recommend deprecated/removed 'extensions:' field
6ad7eef
@mpilgrem mpilgrem mentioned this issue May 22, 2024
Merged
5 tasks
@ulysses4ever ulysses4ever linked a pull request May 23, 2024 that will close this issue
Fix #10042 Don't recommend deprecated/removed 'extensions:' field #10044
Merged
5 tasks
mpilgrem added a commit that referenced this issue May 25, 2024
@mpilgrem
Fix #10042 Don't recommend deprecated/removed 'extensions:' field
bc79b5a
mpilgrem added a commit that referenced this issue May 26, 2024
@mpilgrem
Fix #10042 Don't recommend deprecated/removed 'extensions:' field
dc9a7a0
@mergify mergify bot closed this as completed in #10044 May 28, 2024
mergify bot added a commit that referenced this issue May 28, 2024
@mergify
Merge pull request #10044 from haskell/fix10042
88c81c9 
Fix #10042 Don't recommend deprecated/removed 'extensions:' field
mergify bot pushed a commit that referenced this issue Jun 6, 2024
@mpilgrem @mergify
Fix #10042 Don't recommend deprecated/removed 'extensions:' field
9f54c22 
(cherry picked from commit dc9a7a0)
@mergify mergify bot mentioned this issue Jun 6, 2024
Merged
5 tasks
ulysses4ever pushed a commit that referenced this issue Jun 7, 2024
@mpilgrem @ulysses4ever
Fix #10042 Don't recommend deprecated/removed 'extensions:' field
3a04b13 
(cherry picked from commit dc9a7a0)
mergify bot added a commit that referenced this issue Jun 7, 2024
@mergify @mpilgrem
Fix #10042 Don't recommend deprecated/removed 'extensions:' field (#1…
2d8d7ef 
…0078)

(cherry picked from commit dc9a7a0)

Co-authored-by: Mike Pilgrem <[email protected]>
mmhat pushed a commit to mmhat/cabal that referenced this issue Jun 24, 2024
@mpilgrem @mmhat
Fix haskell#10042 Don't recommend deprecated/removed 'extensions:' field
89e8deb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpilgrem mpilgrem

Labels
attention: pr-welcome re: user experience User experience (UX) issue type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #10042 Don't recommend deprecated/removed 'extensions:' field haskell/cabal
2 participants
@ulysses4ever @mpilgrem