Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example mailer code in README doesn't work #174

Open
obie opened this issue Dec 27, 2016 · 1 comment
Open

Example mailer code in README doesn't work #174

obie opened this issue Dec 27, 2016 · 1 comment

Comments

@obie
Copy link

obie commented Dec 27, 2016

With Rails 5.0.0.1 not supplying id option to expose results in Decent Exposure expecting to have a params object available, which of course doesn't exist in mailers.

Since DE is able to hook into the execution chain between the mailer class and instance action method being invoked, it should be possible to use naming conventions to pluck the needed parameters automatically without need for additional boilerplate assignments.

Sorry, I don't have time to dig into the issue and provide a patch right now. But would love to mention DE in my Action Mailer chapter in The Rails 5 Way if possible.

@jsncmgs1
Copy link

jsncmgs1 commented Feb 1, 2017

Sorry, resources are booked so likely won't be able to get to it in time for your book, but should you find the time, PR's welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants