Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] fullNameOverride and/or nameOverride have no effect #991

Open
miguel-cardoso-mindera opened this issue Dec 19, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@miguel-cardoso-mindera
Copy link

Describe the bug
Installing this helm chart with a lengthily name causes the installation to fail because some resources have more than 63 characters.
Because I'm using ArgoCD, it uses the Application name as the release name, which causes it to be absurdly long. Trying to override this behaviour through fullNameOverride or nameOverride have provided no effect

To Reproduce
Steps to reproduce the behavior:

  1. Deploy helm with a long name, for example my own: microservices-qa-new-vault-operator
  2. Try sync in Argocd
  3. Sync fails:
    one or more objects failed to apply, reason: Service "microservices-qa-new-vault-operator-vault-secrets-operator-metrics-service" is invalid: metadata.name: Invalid value: "microservices-qa-new-vault-operator-vault-secrets-operator-metrics-service": must be no more than 63 characters

Application deployment:

fullNameOverride: vault-secrets-operator

controller:
  replicas: 1

  annotations:
    prometheus.io/path: "/metrics"
    prometheus.io/port: "8443"
    prometheus.io/scrape: "true"

  kubeRbacProxy:
    image:
      repository: quay.io/brancz/kube-rbac-proxy
      tag: v0.18.1
    
    resources:
      limits:
        cpu: 500m
        memory: 128Mi
      requests:
        cpu: 5m
        memory: 64Mi

  manager:
    image:
      repository: hashicorp/vault-secrets-operator
      tag: 0.9.1

    logging:
      level: info
      stacktraceLevel: panic

    resources:
      limits:
        cpu: 500m
        memory: 128Mi
      requests:
        cpu: 10m
        memory: 64Mi

  podSecurityContext:
    runAsNonRoot: true

hooks:
  resources:
    limits:
      cpu: 500m
      memory: 128Mi
    requests:
      cpu: 10m
      memory: 64Mi

  upgradeCRDs:
    enabled: true

Expected behavior
I'd expect my kubernetes resources to be named vault-secrets-operator-...., instead it shows as microservices-qa-new-vault-operator-vault-secrets-operator-...

Environment

  • Kubernetes version: not relevant
    • Distribution or cloud vendor (OpenShift, EKS, GKE, AKS, etc.): GKE
    • Other configuration options or runtime services (istio, etc.): not relevant
  • vault-secrets-operator version: 0.9.1

Additional context
Add any other context about the problem here.

@miguel-cardoso-mindera miguel-cardoso-mindera added the bug Something isn't working label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant