Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pattern: regex to support days (d) #977

Closed
wants to merge 1 commit into from

Conversation

0megam
Copy link

@0megam 0megam commented Nov 27, 2024

While Vault API supports setting ttl and expiryOffset with d suffix CRD is not supporting that.

While Vault API supports setting ttl and expiryOffset with d suffix CRD is not supporting that.
@0megam 0megam requested a review from a team as a code owner November 27, 2024 21:56
Copy link

hashicorp-cla-app bot commented Nov 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@0megam
Copy link
Author

0megam commented Dec 10, 2024

Could someone please review this PR ?
This blocking us from upgrading our VSO to the latest version, because huge amount of services in our k8s clusters are using days(d) in expiryOffset parameter and we do not want to maintain our own version of CRDs.

@benashz benashz self-assigned this Dec 18, 2024
@benashz
Copy link
Collaborator

benashz commented Dec 18, 2024

In order to maintain consistency between the other types, specifying the expiryOffset in days is not supported. The Vault PKI API supports setting a certificate TTL with the units in days. That is addressed in #990.

@benashz benashz closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants