Vagrant 2.2.19 breaks support for CINC

[swagopopotamus]

Vagrant version

Vagrant 2.2.19

Host operating system

MacOS 12.01

Guest operating system

Ubuntu Linux
CentOS Linux

Vagrantfile

    php.vm.provision "chef_zero" do |chef|
      chef.omnibus_url = 'https://omnitruck.cinc.sh/install.sh'
      chef.product = 'cinc'
      chef.version = chef_version
      chef.cookbooks_path = "./cookbooks"
      chef.data_bags_path = "./data_bags"
      chef.nodes_path = "./nodes"

Expected behavior

The provisioner should have installed cinc as it did before and continued to provision the vm

Actual behavior

Vagrant could not detect Chef on the guest! Even after Vagrant
attempted to install Chef, it could still not find Chef on the system.
Please make sure you are connected to the Internet and can access
Chef's package distribution servers. If you already have Chef
installed on this guest, you can disable the automatic Chef detection
by setting the 'install' option in the Chef configuration section of
your Vagrantfile:

    chef.install = false

Steps to reproduce

1. Update vagrant to version 2.2.19
2. Attempt to provision a vm using cinc as defined in Vagrantfile example above
3. See error

References

This seems to have been introduced by the following PR:
#12555

[collinmcneese]

Hey @swagopopotamus -- I just put in a PR which should get this corrected. With the changes in Chef Infra Client 17, knife couldn't be used as the test path any longer for determining if the client was installed so that is where the disconnect was at because the previous PR did not take Cinc into account (it does now, along with Cinc Workstation)

Here is output from a bundle exec vagrant up with the code that is in the PR:

[swagopopotamus]

Thanks @collinmcneese !

[RusHiiii]

@collinmcneese Hi ! I am experiencing the same issue, do you have an idea when this PR will be merged ?

[boblenclume]

@collinmcneese Wow... Did they just close your PR ?!

[RusHiiii]

@collinmcneese We used Chef and Vagrant since many years but with the release of Vagrant 2.2.19 they break the support for CINC and you created a PR last year wich fix the issue (#12606). Recently the PR was closed automatically, and your fork of Vagrant with the fix isn’t available anymore. Do you have any idea how we can fix it ? Recreate a PR ?

[dkd-kaehm]

@collinmcneese
Could you please reopen the PR #12606? The bot did to much and closed and locked nice contribution.

---

Currently only the symlink helps to avoid errors on provision.
ln -sf cinc /opt/chef

For Vagrantfile:

# add before chef provisioner:
config.vm.provision "shell", inline: 'ln -sf cinc /opt/chef'

[everii-mapi]

This issue still persists, creating the symlink via shell provisioner works but should not be needed.

[darkn3rd]

It is really gross that bots are used to close valid contributions.