test: Fix test and update override files to not include any experiment lists in the terraform block.

Author: SarahFrench

internal/configs/parser_config_dir_test.go

@@ -36,16 +36,11 @@ func TestParserLoadConfigDirSuccess(t *testing.T) {
 		t.Run(name, func(t *testing.T) {
 			parser := NewParser(nil)
 
-			var expectWarning bool
 			if strings.Contains(name, "state-store") {
 				// The PSS project is currently gated as experimental
 				// TODO(SarahFrench/radeksimko) - remove this from the test once
 				// the feature is GA.
 				parser.allowExperiments = true
-
-				// While the feature is experimental a warning will always be returned
-				// about the feature.
-				expectWarning = true
 			}
 
 			path := filepath.Join("testdata/valid-modules", name)
@@ -79,19 +74,13 @@ func TestParserLoadConfigDirSuccess(t *testing.T) {
 				diags = filterDiags
 			}
 			if diags.HasErrors() {
-				t.Errorf("unexpected error diagnostics")
+				t.Error("unexpected error diagnostics")
 				for _, diag := range diags.Errs() {
 					t.Logf("- %s", diag)
 				}
 			}
-			if !expectWarning && len(diags) != 0 {
-				t.Errorf("unexpected diagnostics: expected no warnings")
-				for _, diag := range diags {
-					t.Logf("- %s", diag)
-				}
-			}
-			if expectWarning && len(diags) != 1 {
-				t.Errorf("unexpected diagnostics: expected a single warning")
+			if len(diags) > 0 {
+				t.Error("unexpected diagnostics:")
 				for _, diag := range diags {
 					t.Logf("- %s", diag)
 				}

internal/configs/testdata/valid-modules/override-backend-with-state-store/override.tf

@@ -1,4 +1,6 @@
 terraform {
+  # Not including an experiments list here
+  # See https://github.com/hashicorp/terraform/issues/38012
   required_providers {
     foo = {
       source = "my-org/foo"

internal/configs/testdata/valid-modules/override-cloud-with-state-store/override.tf

@@ -1,4 +1,6 @@
 terraform {
+  # Not including an experiments list here
+  # See https://github.com/hashicorp/terraform/issues/38012
   required_providers {
     foo = {
       source = "my-org/foo"

internal/configs/testdata/valid-modules/override-state-store-no-base/override.tf

@@ -1,5 +1,6 @@
 terraform {
-  experiments = [pluggable_state_stores]
+  # Not including an experiments list here
+  # See https://github.com/hashicorp/terraform/issues/38012
   required_providers {
     test = {
       source = "hashicorp/test"

internal/configs/testdata/valid-modules/override-state-store/override.tf

@@ -1,4 +1,6 @@
 terraform {
+  # Not including an experiments list here
+  # See https://github.com/hashicorp/terraform/issues/38012
   required_providers {
     bar = {
       source = "my-org/bar"