Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS list Kubernetes versions #40706

Open
ewbankkit opened this issue Dec 27, 2024 · 8 comments · May be fixed by #40741
Open

EKS list Kubernetes versions #40706

ewbankkit opened this issue Dec 27, 2024 · 8 comments · May be fixed by #40741
Labels
new-data-source Introduces a new data source. service/eks Issues and PRs that pertain to the eks service.

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Dec 27, 2024

Amazon Elastic Kubernetes Service (EKS) now lets you programmatically access availability of Kubernetes versions.

New Data Source(s)

  • aws_eks_cluster_versions
  • aws_eks_cluster_version

Requires AWS SDK for Go v2 Release 2024-12-23: #40687.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit added new-data-source Introduces a new data source. service/eks Issues and PRs that pertain to the eks service. labels Dec 27, 2024
@ewbankkit ewbankkit changed the title EKS Kubenetes version availability EKS list Kubernetes versions Dec 27, 2024
@hjoshi123
Copy link
Contributor

@ewbankkit Can I work on this?

@hjoshi123
Copy link
Contributor

@ewbankkit is it okay to upgrade the deps to work on this task and we can merge the main into this once the deps are upgraded in main?

@ewbankkit
Copy link
Contributor Author

@hjoshi123 Yes, as we are waiting on a resolution to aws/aws-sdk-go-v2#2939 before we can merge the full set of AWS SDK for Go v2 updates, I suggest go get github.com/aws/aws-sdk-go-v2/service/eks && go mod tidy to take just the EKS upgrade.

@hjoshi123
Copy link
Contributor

Yup that's what I thought too. Thanks for confirming @ewbankkit

@hjoshi123
Copy link
Contributor

@ewbankkit I am done with implementing aws_eks_cluster_versions data source was wondering if we need aws_eks_cluster_version data source since the API always returns an array and it doesnt give any unique identifier to query to get an individual result out of it. For example this is how the command looks like

 aws eks describe-cluster-versions --cluster-version=1.31
{
    "clusterVersions": [
        {
            "clusterVersion": "1.31",
            "clusterType": "eks",
            "defaultPlatformVersion": "eks.16",
            "defaultVersion": true,
            "releaseDate": "2024-09-25T18:00:00-06:00",
            "endOfStandardSupportDate": "2025-11-25T17:00:00-07:00",
            "endOfExtendedSupportDate": "2026-11-25T17:00:00-07:00",
            "status": "STANDARD_SUPPORT",
            "kubernetesPatchVersion": "1.31.4"
        }
    ]
}

So I was wondering what was the reasoning behind having another data source?

@hjoshi123
Copy link
Contributor

Also, @ewbankkit might have found another bug on the upstream sdk.. the CLI and the Call to DescribeClusterVersions API returns the status as "status": "STANDARD_SUPPORT" or EXTENDED_SUPPORT however, the enum types on their SDK is mapped to the below which makes the acceptance test fail

ClusterVersionStatusUnsupported     ClusterVersionStatus = "unsupported"
	ClusterVersionStatusStandardSupport ClusterVersionStatus = "standard-support"
	ClusterVersionStatusExtendedSupport ClusterVersionStatus = "extended-support"

I am not sure what to do. Is this something we have to raise an issue on the aws sdk side?

@hjoshi123 hjoshi123 linked a pull request Jan 1, 2025 that will close this issue
@hjoshi123
Copy link
Contributor

Raised the following PR on upstream aws/aws-sdk-go-v2#2942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-data-source Introduces a new data source. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants