Skip to content

Commit 7a8669e

Browse files
YakDriverYakDriver
authored
Merge pull request #40047 from hashicorp/f-taxsettings
feat: new service `taxsettings`
2 parents b46b42d + 7083b0d commit 7a8669e

23 files changed

+962
-91
lines changed

‎.ci/.semgrep-service-name0.yml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4296,3 +4296,22 @@ rules:
42964296
patterns:
42974297
- pattern-regex: "(?i)ConfigService"
42984298
severity: WARNING
4299+
- id: connect-in-func-name
4300+
languages:
4301+
- go
4302+
message: Do not use "Connect" in func name inside connect package
4303+
paths:
4304+
include:
4305+
- internal/service/connect
4306+
exclude:
4307+
- internal/service/connect/list_pages_gen.go
4308+
patterns:
4309+
- pattern: func $NAME( ... )
4310+
- metavariable-pattern:
4311+
metavariable: $NAME
4312+
patterns:
4313+
- pattern-regex: "(?i)Connect"
4314+
- pattern-not-regex: .*uickConnect.*
4315+
- focus-metavariable: $NAME
4316+
- pattern-not: func $NAME($T *testing.T)
4317+
severity: WARNING

‎.ci/.semgrep-service-name1.yml‎

Lines changed: 29 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,5 @@
11
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
22
rules:
3-
- id: connect-in-func-name
4-
languages:
5-
- go
6-
message: Do not use "Connect" in func name inside connect package
7-
paths:
8-
include:
9-
- internal/service/connect
10-
exclude:
11-
- internal/service/connect/list_pages_gen.go
12-
patterns:
13-
- pattern: func $NAME( ... )
14-
- metavariable-pattern:
15-
metavariable: $NAME
16-
patterns:
17-
- pattern-regex: "(?i)Connect"
18-
- pattern-not-regex: .*uickConnect.*
19-
- focus-metavariable: $NAME
20-
- pattern-not: func $NAME($T *testing.T)
21-
severity: WARNING
223
- id: connect-in-test-name
234
languages:
245
- go
@@ -4295,3 +4276,32 @@ rules:
42954276
- focus-metavariable: $NAME
42964277
- pattern-not: func $NAME($T *testing.T)
42974278
severity: WARNING
4279+
- id: iotanalytics-in-test-name
4280+
languages:
4281+
- go
4282+
message: Include "IoTAnalytics" in test name
4283+
paths:
4284+
include:
4285+
- internal/service/iotanalytics/*_test.go
4286+
patterns:
4287+
- pattern: func $NAME( ... )
4288+
- metavariable-pattern:
4289+
metavariable: $NAME
4290+
patterns:
4291+
- pattern-not-regex: "^TestAccIoTAnalytics"
4292+
- pattern-regex: ^TestAcc.*
4293+
severity: WARNING
4294+
- id: iotanalytics-in-const-name
4295+
languages:
4296+
- go
4297+
message: Do not use "IoTAnalytics" in const name inside iotanalytics package
4298+
paths:
4299+
include:
4300+
- internal/service/iotanalytics
4301+
patterns:
4302+
- pattern: const $NAME = ...
4303+
- metavariable-pattern:
4304+
metavariable: $NAME
4305+
patterns:
4306+
- pattern-regex: "(?i)IoTAnalytics"
4307+
severity: WARNING

‎.ci/.semgrep-service-name2.yml‎

Lines changed: 43 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,5 @@
11
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
22
rules:
3-
- id: iotanalytics-in-test-name
4-
languages:
5-
- go
6-
message: Include "IoTAnalytics" in test name
7-
paths:
8-
include:
9-
- internal/service/iotanalytics/*_test.go
10-
patterns:
11-
- pattern: func $NAME( ... )
12-
- metavariable-pattern:
13-
metavariable: $NAME
14-
patterns:
15-
- pattern-not-regex: "^TestAccIoTAnalytics"
16-
- pattern-regex: ^TestAcc.*
17-
severity: WARNING
18-
- id: iotanalytics-in-const-name
19-
languages:
20-
- go
21-
message: Do not use "IoTAnalytics" in const name inside iotanalytics package
22-
paths:
23-
include:
24-
- internal/service/iotanalytics
25-
patterns:
26-
- pattern: const $NAME = ...
27-
- metavariable-pattern:
28-
metavariable: $NAME
29-
patterns:
30-
- pattern-regex: "(?i)IoTAnalytics"
31-
severity: WARNING
323
- id: iotanalytics-in-var-name
334
languages:
345
- go
@@ -4294,3 +4265,46 @@ rules:
42944265
- focus-metavariable: $NAME
42954266
- pattern-not: func $NAME($T *testing.T)
42964267
severity: WARNING
4268+
- id: redshift-in-test-name
4269+
languages:
4270+
- go
4271+
message: Include "Redshift" in test name
4272+
paths:
4273+
include:
4274+
- internal/service/redshift/*_test.go
4275+
patterns:
4276+
- pattern: func $NAME( ... )
4277+
- metavariable-pattern:
4278+
metavariable: $NAME
4279+
patterns:
4280+
- pattern-not-regex: "^TestAccRedshift"
4281+
- pattern-regex: ^TestAcc.*
4282+
severity: WARNING
4283+
- id: redshift-in-const-name
4284+
languages:
4285+
- go
4286+
message: Do not use "Redshift" in const name inside redshift package
4287+
paths:
4288+
include:
4289+
- internal/service/redshift
4290+
patterns:
4291+
- pattern: const $NAME = ...
4292+
- metavariable-pattern:
4293+
metavariable: $NAME
4294+
patterns:
4295+
- pattern-regex: "(?i)Redshift"
4296+
severity: WARNING
4297+
- id: redshift-in-var-name
4298+
languages:
4299+
- go
4300+
message: Do not use "Redshift" in var name inside redshift package
4301+
paths:
4302+
include:
4303+
- internal/service/redshift
4304+
patterns:
4305+
- pattern: var $NAME = ...
4306+
- metavariable-pattern:
4307+
metavariable: $NAME
4308+
patterns:
4309+
- pattern-regex: "(?i)Redshift"
4310+
severity: WARNING

‎.ci/.semgrep-service-name3.yml‎

Lines changed: 61 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -1,48 +1,5 @@
11
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
22
rules:
3-
- id: redshift-in-test-name
4-
languages:
5-
- go
6-
message: Include "Redshift" in test name
7-
paths:
8-
include:
9-
- internal/service/redshift/*_test.go
10-
patterns:
11-
- pattern: func $NAME( ... )
12-
- metavariable-pattern:
13-
metavariable: $NAME
14-
patterns:
15-
- pattern-not-regex: "^TestAccRedshift"
16-
- pattern-regex: ^TestAcc.*
17-
severity: WARNING
18-
- id: redshift-in-const-name
19-
languages:
20-
- go
21-
message: Do not use "Redshift" in const name inside redshift package
22-
paths:
23-
include:
24-
- internal/service/redshift
25-
patterns:
26-
- pattern: const $NAME = ...
27-
- metavariable-pattern:
28-
metavariable: $NAME
29-
patterns:
30-
- pattern-regex: "(?i)Redshift"
31-
severity: WARNING
32-
- id: redshift-in-var-name
33-
languages:
34-
- go
35-
message: Do not use "Redshift" in var name inside redshift package
36-
paths:
37-
include:
38-
- internal/service/redshift
39-
patterns:
40-
- pattern: var $NAME = ...
41-
- metavariable-pattern:
42-
metavariable: $NAME
43-
patterns:
44-
- pattern-regex: "(?i)Redshift"
45-
severity: WARNING
463
- id: redshiftdata-in-func-name
474
languages:
485
- go
@@ -3293,6 +3250,67 @@ rules:
32933250
patterns:
32943251
- pattern-regex: "(?i)Synthetics"
32953252
severity: WARNING
3253+
- id: taxsettings-in-func-name
3254+
languages:
3255+
- go
3256+
message: Do not use "TaxSettings" in func name inside taxsettings package
3257+
paths:
3258+
include:
3259+
- internal/service/taxsettings
3260+
exclude:
3261+
- internal/service/taxsettings/list_pages_gen.go
3262+
patterns:
3263+
- pattern: func $NAME( ... )
3264+
- metavariable-pattern:
3265+
metavariable: $NAME
3266+
patterns:
3267+
- pattern-regex: "(?i)TaxSettings"
3268+
- focus-metavariable: $NAME
3269+
- pattern-not: func $NAME($T *testing.T)
3270+
severity: WARNING
3271+
- id: taxsettings-in-test-name
3272+
languages:
3273+
- go
3274+
message: Include "TaxSettings" in test name
3275+
paths:
3276+
include:
3277+
- internal/service/taxsettings/*_test.go
3278+
patterns:
3279+
- pattern: func $NAME( ... )
3280+
- metavariable-pattern:
3281+
metavariable: $NAME
3282+
patterns:
3283+
- pattern-not-regex: "^TestAccTaxSettings"
3284+
- pattern-regex: ^TestAcc.*
3285+
severity: WARNING
3286+
- id: taxsettings-in-const-name
3287+
languages:
3288+
- go
3289+
message: Do not use "TaxSettings" in const name inside taxsettings package
3290+
paths:
3291+
include:
3292+
- internal/service/taxsettings
3293+
patterns:
3294+
- pattern: const $NAME = ...
3295+
- metavariable-pattern:
3296+
metavariable: $NAME
3297+
patterns:
3298+
- pattern-regex: "(?i)TaxSettings"
3299+
severity: WARNING
3300+
- id: taxsettings-in-var-name
3301+
languages:
3302+
- go
3303+
message: Do not use "TaxSettings" in var name inside taxsettings package
3304+
paths:
3305+
include:
3306+
- internal/service/taxsettings
3307+
patterns:
3308+
- pattern: var $NAME = ...
3309+
- metavariable-pattern:
3310+
metavariable: $NAME
3311+
patterns:
3312+
- pattern-regex: "(?i)TaxSettings"
3313+
severity: WARNING
32963314
- id: timestreaminfluxdb-in-func-name
32973315
languages:
32983316
- go

‎.github/labeler-issue-triage.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -679,6 +679,8 @@ service/swf:
679679
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_swf_'
680680
service/synthetics:
681681
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_synthetics_'
682+
service/taxsettings:
683+
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_taxsettings_'
682684
service/textract:
683685
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_textract_'
684686
service/timestreaminfluxdb:

‎.github/labeler-pr-triage.yml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2130,6 +2130,12 @@ service/synthetics:
21302130
- any-glob-to-any-file:
21312131
- 'internal/service/synthetics/**/*'
21322132
- 'website/**/synthetics_*'
2133+
service/taxsettings:
2134+
- any:
2135+
- changed-files:
2136+
- any-glob-to-any-file:
2137+
- 'internal/service/taxsettings/**/*'
2138+
- 'website/**/taxsettings_*'
21332139
service/textract:
21342140
- any:
21352141
- changed-files:

‎.teamcity/components/generated/services_all.kt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ val services = mapOf(
231231
"sts" to ServiceSpec("STS (Security Token)"),
232232
"swf" to ServiceSpec("SWF (Simple Workflow)"),
233233
"synthetics" to ServiceSpec("CloudWatch Synthetics", parallelismOverride = 10),
234+
"taxsettings" to ServiceSpec("Tax Settings"),
234235
"timestreaminfluxdb" to ServiceSpec("Timestream for InfluxDB", vpcLock = true, parallelismOverride = 3),
235236
"timestreamwrite" to ServiceSpec("Timestream Write"),
236237
"transcribe" to ServiceSpec("Transcribe"),

‎go.mod‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@ require (
245245
github.com/aws/aws-sdk-go-v2/service/sts v1.32.4
246246
github.com/aws/aws-sdk-go-v2/service/swf v1.27.4
247247
github.com/aws/aws-sdk-go-v2/service/synthetics v1.29.4
248+
github.com/aws/aws-sdk-go-v2/service/taxsettings v1.6.1
248249
github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb v1.6.4
249250
github.com/aws/aws-sdk-go-v2/service/timestreamwrite v1.29.4
250251
github.com/aws/aws-sdk-go-v2/service/transcribe v1.41.4

‎go.sum‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -514,6 +514,8 @@ github.com/aws/aws-sdk-go-v2/service/swf v1.27.4 h1:lmYFiiZ+VCGgqt2d1xHSfp0SN7kD
514514
github.com/aws/aws-sdk-go-v2/service/swf v1.27.4/go.mod h1:7Is8HtyC+vQskJFxErP7YoF/Zu6/FeQ7w8DHbyqx0Hk=
515515
github.com/aws/aws-sdk-go-v2/service/synthetics v1.29.4 h1:LbOEGGiQv21rDS5uG+6accj80J0Ge7f6vKNvXaPyhOc=
516516
github.com/aws/aws-sdk-go-v2/service/synthetics v1.29.4/go.mod h1:h/0XMdglPF+MHuq0zLeN9SCedbW0CJ4/5T/ggtDs+s0=
517+
github.com/aws/aws-sdk-go-v2/service/taxsettings v1.6.1 h1:kper8FCLg9zRFT3/ez1/XwDKdeEfo7nebvBmZOZn37U=
518+
github.com/aws/aws-sdk-go-v2/service/taxsettings v1.6.1/go.mod h1:tmVIxtzE4zvoK4LaWFOqeAUl1oZmR3SiT42gfmoveWY=
517519
github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb v1.6.4 h1:p23Zsb1kHKA6lZsVTXkUC67v0MyMtEwnFsFBA2/M3TE=
518520
github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb v1.6.4/go.mod h1:tFPhAm5lWLaxKyZ8kC91+t1DtNf2wfxK8mxAkc0psHU=
519521
github.com/aws/aws-sdk-go-v2/service/timestreamwrite v1.29.4 h1:0+lRed/3INQCDdfhtw3kBv1P2ZNNxokoXSRALp/Vhhg=

‎infrastructure/repository/labels-service.tf‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@ variable "service_labels" {
326326
"support",
327327
"swf",
328328
"synthetics",
329+
"taxsettings",
329330
"textract",
330331
"timestreaminfluxdb",
331332
"timestreamquery",

0 commit comments

Comments
 (0)