Remove x5t Header Check (#452)

* Remove x5t Header Check

This check doesn't exist on the Terraform provider, and was added in the initial commit of this builder.  It's a very old change that I do not think is required anymore

An Azure employee reported that with entra minted tokens, this validation causes failures: #451

* Remove thumbprint x5t test

Author: JenGoldstrich

builder/azure/common/client/config.go

@@ -211,15 +211,10 @@ func (c Config) Validate(errs *packersdk.MultiError) {
 		c.ClientJWT != "" {
 		p := jwt.Parser{}
 		claims := jwt.StandardClaims{}
-		token, _, err := p.ParseUnverified(c.ClientJWT, &claims)
+		_, _, err := p.ParseUnverified(c.ClientJWT, &claims)
 		if err != nil {
 			errs = packersdk.MultiErrorAppend(errs, fmt.Errorf("client_jwt is not a JWT: %v", err))
-		} else {
-			if t, ok := token.Header["x5t"]; !ok || t == "" {
-				errs = packersdk.MultiErrorAppend(errs, fmt.Errorf("client_jwt is missing the x5t header value, which is required for bearer JWT client authentication to Azure"))
-			}
 		}
-
 		return
 	}
 

builder/azure/common/client/config_test.go

@@ -304,16 +304,6 @@ func Test_ClientConfig_CannotUseBothClientJWTAndSecret(t *testing.T) {
 	assertInvalid(t, cfg)
 }
 
-func Test_ClientConfig_ClientJWTShouldHaveThumbprint(t *testing.T) {
-	cfg := Config{
-		SubscriptionID: "12345",
-		ClientID:       "12345",
-		ClientJWT:      getJWT(10*time.Minute, false),
-	}
-
-	assertInvalid(t, cfg)
-}
-
 func Test_getJWT(t *testing.T) {
 	if getJWT(time.Minute, true) == "" {
 		t.Fatalf("getJWT is broken")