fix lint errors

Author: Abhijeet V

args.go

@@ -187,9 +187,7 @@ type ConverterGenFunc func(Value) (*Func, error)
 // If the function returns a nil Func, then no converter is generated.
 func ConverterGen(fs ...ConverterGenFunc) Arg {
 	return func(a *argBuilder) error {
-		for _, f := range fs {
-			a.convGens = append(a.convGens, f)
-		}
+		a.convGens = append(a.convGens, fs...)
 		return nil
 	}
 }

call.go

@@ -225,7 +225,6 @@ func (f *Func) callGraph(args *argBuilder) (
 			include := true
 			if args.filterInput != nil && !args.filterInput(value) {
 				log.Trace("excluding input due to failed filter", "value", value)
-				include = false
 				continue
 			}
 
@@ -255,7 +254,7 @@ func (f *Func) callGraph(args *argBuilder) (
 		// other zero index topo sort value.
 		graph.VertexID(vertexRoot): struct{}{},
 	}
-	g.Reverse().DFS(vertexRoot, func(v graph.Vertex, next func() error) error {
+	_ = g.Reverse().DFS(vertexRoot, func(v graph.Vertex, next func() error) error {
 		visited[graph.VertexID(v)] = struct{}{}
 
 		if v == vertexF {
@@ -577,6 +576,7 @@ func (f *Func) callDirect(log hclog.Logger, argMap map[interface{}]reflect.Value
 			// This should never happen because we catch unsatisfied errors
 			// earlier in the process. Because of this, we output a message
 			// that there is a bug.
+			//nolint:staticcheck // ST1005 Consumers maybe relying on the error message.
 			buildErr = multierror.Append(buildErr, fmt.Errorf(
 				"argument cannot be satisfied: %s. This is a bug in "+
 					"the go-argmapper library since this shouldn't happen at this "+

func_test.go

@@ -1414,6 +1414,7 @@ func TestBuildFunc_errValue(t *testing.T) {
 	f, err = BuildFunc(input, f.Output(), func(in, out *ValueSet) error {
 		return fmt.Errorf("some error")
 	})
+	require.NoError(err)
 
 	require.EqualError(f.Output().FromResult(f.Call(Named("a", 12))), "some error")
 }

graph.go

@@ -12,6 +12,7 @@ import (
 
 const (
 	// weightNormal is the typcal edge weight.
+	//nolint:unused
 	weightNormal = 1
 
 	// weightTyped is the weight to use for edges that connected to any

internal/graph/dijkstra.go

@@ -21,7 +21,7 @@ func (g *Graph) Dijkstra(src Vertex) (distTo map[interface{}]int, edgeTo map[int
 	*/
 	queue := make(distQueue, 0, len(g.hash))
 	queueItem := map[interface{}]*distQueueItem{}
-	for k, _ := range g.hash {
+	for k := range g.hash {
 		item := &distQueueItem{
 			v:        k,
 			distance: math.MaxInt32,

internal/graph/vertex.go

@@ -24,7 +24,7 @@ func VertexID(v Vertex) interface{} {
 func VertexName(v Vertex) string {
 	switch v := v.(type) {
 	case fmt.Stringer:
-		return fmt.Sprintf("%s", v)
+		return v.String()
 	default:
 		return fmt.Sprintf("%v", v)
 	}