Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CheckUpdateInterval configurable or document it #267

Open
danielehc opened this issue Jun 20, 2024 · 2 comments
Open

Make CheckUpdateInterval configurable or document it #267

danielehc opened this issue Jun 20, 2024 · 2 comments

Comments

@danielehc
Copy link

Current Issue

When adding new external services to Consul it takes 5+ minutes for them to change status from Failing to Healthy even if

  • the node_probe_interval in Consul ESM configuration is set to 10s
  • the Service.Check.Interval in the service configuration is set to 10s

This is confusing and leads to the idea that something is not working in the background.

From my understanding of the code the behavior is due to the CheckUpdateInterval configuration value that:

  • Is not configurable from the configuration file
  • Is not documented on the Github repository

Proposed solution

To avoid this confusion is either possible:

  1. Allow for the configuration of the CheckUpdateInterval in Consul ESM configuration file
  2. Document the expected behavior in the README mentioning that after adding new nodes to Consul, Consul ESM will take up to 5 minutes to identify them and to start performing checks.
@Esity
Copy link

Esity commented Sep 15, 2024

We have seen this exact thing, 100% agree with this request, CC @blake

@Esity
Copy link

Esity commented Sep 15, 2024

@danielehc , does #256 fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants